From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 2/2]: conntrack: kill destroy() in struct nf_conntrack for diet
Date: Tue, 20 Mar 2007 07:34:36 +0100 [thread overview]
Message-ID: <45FF807C.3020801@trash.net> (raw)
In-Reply-To: <200703200607.l2K67Piq025156@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> #if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
> -static inline void nf_conntrack_put(struct nf_conntrack *nfct)
> -{
> - if (nfct && atomic_dec_and_test(&nfct->use))
> - nfct->destroy(nfct);
> -}
Also applied. I wonder whether we should keep this inline and
just have the final destruction be performed out of line, its
called in a few quite performance critical paths.
next parent reply other threads:[~2007-03-20 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200703200607.l2K67Piq025156@toshiba.co.jp>
2007-03-20 6:34 ` Patrick McHardy [this message]
2007-03-23 13:59 ` [PATCH 2/2]: conntrack: kill destroy() in struct nf_conntrack for diet Patrick McHardy
2007-03-24 9:06 ` Yasuyuki KOZAKAI
2007-03-20 6:07 Yasuyuki KOZAKAI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FF807C.3020801@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.