All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jaya Kumar" <jayakumar.alsa@gmail.com>
To: "Andres Salomon" <dilinger@queued.net>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 4/4] ALSA: cs5535audio: OLPC Analog Input and MIC Bias support
Date: Thu, 6 Nov 2008 08:22:30 +0800	[thread overview]
Message-ID: <45a44e480811051622g3b81ad71tad9ca5a341fedbcc@mail.gmail.com> (raw)
In-Reply-To: <20081105173113.06e93db3@ephemeral>

On Thu, Nov 6, 2008 at 6:31 AM, Andres Salomon <dilinger@queued.net> wrote:
>
> This adds support for the special cs5535audio features that OLPC XO-1s have.
> They support switching between analog and DC recording, and the MIC requires
> toggling V_REFOUT (which this patch renames to MIC Bias) to operate.  There's
> also an EAPD tweak which is necessary for B3 and newer machines.
>
> All of this is enabled by CONFIG_OLPC (and CONFIG_SND_CS5535AUDIO, obviously).
>
> Signed-off-by: Andres Salomon <dilinger@debian.org>


Andres,

Looks okay. But can you send this patch split into 2 patches? One, the
original cs5535audio_olpc.c that I posted and your changes to it since
then. That'll make it easier for me to review.

Thanks,
jaya

      reply	other threads:[~2008-11-06  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-05 22:31 [PATCH 4/4] ALSA: cs5535audio: OLPC Analog Input and MIC Bias support Andres Salomon
2008-11-06  0:22 ` Jaya Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45a44e480811051622g3b81ad71tad9ca5a341fedbcc@mail.gmail.com \
    --to=jayakumar.alsa@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dilinger@queued.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.