From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70369C433DB for ; Mon, 18 Jan 2021 13:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3815B20E65 for ; Mon, 18 Jan 2021 13:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392190AbhARNld (ORCPT ); Mon, 18 Jan 2021 08:41:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56104 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404669AbhARNkS (ORCPT ); Mon, 18 Jan 2021 08:40:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610977131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AYQO73uwXR/ZL0KjvgARb0aP86zDIIQGfBxMVvC8Sn4=; b=N0lXgeVps9CwauWJT3GtC8jEm/NhWljmL0uIJa/fpFB6FPmXwl2WdH3hwFGUNXM8d1GCug h4irreTdhTenLRf3jVw/h0fxa34HO6t4KkYqIiyUYurGgZbm1SCYoN5g3eToo7BDl5e1yk v+f3SKi77Lwu2gpmjxEXL2Dje9LXxGc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-Tt_6qF2FMfWIah65hz09qg-1; Mon, 18 Jan 2021 08:38:49 -0500 X-MC-Unique: Tt_6qF2FMfWIah65hz09qg-1 Received: by mail-ej1-f70.google.com with SMTP id f26so5190567ejy.9 for ; Mon, 18 Jan 2021 05:38:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AYQO73uwXR/ZL0KjvgARb0aP86zDIIQGfBxMVvC8Sn4=; b=kvOBDo00I7mit6Fjmib4gLa9kjKN/IK0hCEFfwIaWgyPJflphkTeklz+y3iW2BCT7/ fKAemCwWak1kCl5W0DbRnDZm9mtPsQpinl5UB0dH8blRDhQ3xnvPR9mdn9bZhM3JtCRA Q8YCqqUjrrXmYj2Aq9LdzxE0iv57W0kEbctqbB+ta/rusV5lf4ww8J2WAQ5o1LQgqfsw NCd0kHeyQnc9ePm4+h/rX9MDrmHhjlwam4ClvIesyTWswCYy/hskiXMiJLS2T2BRacYk flY0YlHg7ZdcawiLuF9SWnQw7Fl0/BVCxg6GREzABV6jiB5aqaWetP66DajpRPS2Dh7R ORmQ== X-Gm-Message-State: AOAM5332aiQqh66eCpK7GF/d3xk4djA64EQciQGowwnDQh0ckiA6zEGT J6zQctFbbhXX4TN9CLJCYAdrP4fx/8YtuY3hiUbEjsDjsLDw6uteEI73acchGMbf0Mq5G4Avucs lq28jMYQZrRXUoiDtY0wnYoVp X-Received: by 2002:a17:906:1701:: with SMTP id c1mr17201946eje.395.1610977128397; Mon, 18 Jan 2021 05:38:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzs9Mb0hyp3+/u1P/YLkrfyR15h8tNHy4A8YnxJgQj8rrfaGCKzEE7napeuqoudh9UX1EuRhw== X-Received: by 2002:a17:906:1701:: with SMTP id c1mr17201937eje.395.1610977128246; Mon, 18 Jan 2021 05:38:48 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id n6sm2542455ejg.102.2021.01.18.05.38.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 05:38:47 -0800 (PST) Subject: Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI To: Mark Brown Cc: Lee Jones , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Jie Yang , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Andy Shevchenko , Charles Keepax , alsa-devel@alsa-project.org, Christian Hartmann References: <20210117212252.206115-1-hdegoede@redhat.com> <20210117212252.206115-4-hdegoede@redhat.com> <20210118130227.GI4455@sirena.org.uk> <5ccf48f4-45dc-3a30-3d6a-cce066f01270@redhat.com> <20210118133449.GL4455@sirena.org.uk> From: Hans de Goede Message-ID: <45a5de45-d7d9-8505-9009-3774a444f70f@redhat.com> Date: Mon, 18 Jan 2021 14:38:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210118133449.GL4455@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 1/18/21 2:34 PM, Mark Brown wrote: > On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote: > >> More in general I'm not aware of any (recent-ish) x86 GPIO controllers >> not being able to do active low interrupts. In theory we could hit this >> code path on ARM devices using ACPI enumeration, but I don't think it >> is likely we will see a combination of ARM + ACPI enumeration + >> WM5102 + GPIO controller not capable of active-low interrupts. > > I've not seen this issue on any ARM based systems. > >> This overriding of the flags definitely is necessary on the Lenovo >> devices in question. I could add a >> "if (dmi_name_in_vendors("LENOVO"))" guard around it, but that >> seems unnecessary. > > Possibly just an update to the comment to make it clear that some > firmwares might legitimately set the flag That seems sensible, I will wait a bit to so if you (or someone) has any more review remarks to this series and then send out a v4 with the comment updated. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 467CEC433E0 for ; Mon, 18 Jan 2021 13:39:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 283E82065E for ; Mon, 18 Jan 2021 13:39:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 283E82065E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0B7691825; Mon, 18 Jan 2021 14:38:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0B7691825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610977189; bh=sJuxReEOnD40f5KlRcCpImbmJVHJTqpDeA4+g5o582U=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Ei8Syb7o/h1VroWae28fA1CuP6TsS24XKI6n5sxAnVfsnBie8fagqRRkuyVxtXE+/ 0EeWKZUYhldGP7y7HtE/cYT1W404HeR8TY96OqUTUmOQbYsQ61fazmAoe30YG1eiRd ycu/04W70rrYvCySlGSn5VXodboSwRAsB7k5Nbk0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7956BF80166; Mon, 18 Jan 2021 14:38:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4A8E5F8016E; Mon, 18 Jan 2021 14:38:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8E4F1F800C0 for ; Mon, 18 Jan 2021 14:38:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8E4F1F800C0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N0lXgeVp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610977131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AYQO73uwXR/ZL0KjvgARb0aP86zDIIQGfBxMVvC8Sn4=; b=N0lXgeVps9CwauWJT3GtC8jEm/NhWljmL0uIJa/fpFB6FPmXwl2WdH3hwFGUNXM8d1GCug h4irreTdhTenLRf3jVw/h0fxa34HO6t4KkYqIiyUYurGgZbm1SCYoN5g3eToo7BDl5e1yk v+f3SKi77Lwu2gpmjxEXL2Dje9LXxGc= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-vwPHQPsfMre12NgT1K8jJQ-1; Mon, 18 Jan 2021 08:38:49 -0500 X-MC-Unique: vwPHQPsfMre12NgT1K8jJQ-1 Received: by mail-ej1-f72.google.com with SMTP id md20so681258ejb.7 for ; Mon, 18 Jan 2021 05:38:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AYQO73uwXR/ZL0KjvgARb0aP86zDIIQGfBxMVvC8Sn4=; b=rRxF1f7LZ675Y5sNiJpjt1cPEPLZEKAp6aEpeVk6KX4iEJQvZ2msAJ12eIfb9VlGT+ /VbH5uUFIG4lFhzu4uTv/WIiUwRpfxoTmzBC/A5RWHArswMl3MMxMcl7SXKzyvdDGUFE 2cgE7JaGQL/teRFTXRmf27KlzK2IRvLYHWpKV3wumA5IUyo491rdFHp0kUit3MLw8HjZ 9brftuBpsHv5vhej/EveDh37zYSzJHBqsrizG/yyhVyCmee9O/T7UST4xMHF4bmIoefc hcRmKEhOXrK+4ItOonCwqfRy31hMzZAEIxlDj8jwqOtEjDTh4ReU7OhzwEXfuRxgKBiI IIHg== X-Gm-Message-State: AOAM5306a3a5LbNJHo7ubls5rfX/4+vTVAs3oX51wv1n3MbU3GOPjlwl zJRLcxprv3fV57YZcRcbqbW6V0xqAqc9YD0mQe+JQwPy/NobmxQ+lkS8PEgZYxyBy/3w+GcOM5c 97ZJ5fj0bjWoMz9VMmQepOxw= X-Received: by 2002:a17:906:1701:: with SMTP id c1mr17201947eje.395.1610977128398; Mon, 18 Jan 2021 05:38:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJzs9Mb0hyp3+/u1P/YLkrfyR15h8tNHy4A8YnxJgQj8rrfaGCKzEE7napeuqoudh9UX1EuRhw== X-Received: by 2002:a17:906:1701:: with SMTP id c1mr17201937eje.395.1610977128246; Mon, 18 Jan 2021 05:38:48 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id n6sm2542455ejg.102.2021.01.18.05.38.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 05:38:47 -0800 (PST) Subject: Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI To: Mark Brown References: <20210117212252.206115-1-hdegoede@redhat.com> <20210117212252.206115-4-hdegoede@redhat.com> <20210118130227.GI4455@sirena.org.uk> <5ccf48f4-45dc-3a30-3d6a-cce066f01270@redhat.com> <20210118133449.GL4455@sirena.org.uk> From: Hans de Goede Message-ID: <45a5de45-d7d9-8505-9009-3774a444f70f@redhat.com> Date: Mon, 18 Jan 2021 14:38:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210118133449.GL4455@sirena.org.uk> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Cezary Rojewski , Charles Keepax , Christian Hartmann , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jie Yang , Pierre-Louis Bossart , linux-kernel@vger.kernel.org, Liam Girdwood , Andy Shevchenko , Lee Jones X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On 1/18/21 2:34 PM, Mark Brown wrote: > On Mon, Jan 18, 2021 at 02:13:50PM +0100, Hans de Goede wrote: > >> More in general I'm not aware of any (recent-ish) x86 GPIO controllers >> not being able to do active low interrupts. In theory we could hit this >> code path on ARM devices using ACPI enumeration, but I don't think it >> is likely we will see a combination of ARM + ACPI enumeration + >> WM5102 + GPIO controller not capable of active-low interrupts. > > I've not seen this issue on any ARM based systems. > >> This overriding of the flags definitely is necessary on the Lenovo >> devices in question. I could add a >> "if (dmi_name_in_vendors("LENOVO"))" guard around it, but that >> seems unnecessary. > > Possibly just an update to the comment to make it clear that some > firmwares might legitimately set the flag That seems sensible, I will wait a bit to so if you (or someone) has any more review remarks to this series and then send out a v4 with the comment updated. Regards, Hans