From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Teddy Astie <teddy.astie@vates.tech>, xen-devel@lists.xenproject.org
Cc: "Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/hap: Inline "flush_vcpu" in "flush_tlb"
Date: Mon, 29 Sep 2025 21:39:21 +0200 [thread overview]
Message-ID: <45afdc14-7337-4786-b3ff-e3c07a6b5f71@citrix.com> (raw)
In-Reply-To: <bb570008f237cb77f2c74c5f025375ca6c4f140a.1759148418.git.teddy.astie@vates.tech>
On 29/09/2025 1:36 pm, Teddy Astie wrote:
> flush_vcpu static function here is only used in one place which is just below
> where it is defined. Inline the function to reduce the noise and clarify
> what we are doing.
>
> No functional change.
>
> Signed-off-by: Teddy Astie <teddy.astie@vates.tech>
Have you read the commit message introducing this pattern? It's
11d9e114b53045e5f2009a26dad1d0d0f7df441e for reference.
The compiler will do the sensible thing. What matters is the cognitive
complexity of the source code.
~Andrew
next prev parent reply other threads:[~2025-09-29 19:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 12:36 [PATCH] x86/hap: Inline "flush_vcpu" in "flush_tlb" Teddy Astie
2025-09-29 14:06 ` Roger Pau Monné
2025-09-29 15:48 ` Teddy Astie
2025-09-29 19:39 ` Andrew Cooper [this message]
2025-09-30 12:11 ` Teddy Astie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45afdc14-7337-4786-b3ff-e3c07a6b5f71@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.