From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1591EC433F5 for ; Mon, 6 Dec 2021 09:06:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CklTb6YVqklbIq2W4AMrElUf6Csq0FX95T8+DXcZmaE=; b=IBnPIsJXPcsoWc XoZkoITsZnQJ7unuCq2iAN4+lPT6te8aFkAsfEYyVkvVgpzaVzHkeSPyqXgCTXAfuzVvGdcXgKdYL 33iG3DX8WrA5qA3iPWbmAyaOBrkh4q6xXiVu4L12W3lyAFCyKyTL2iq1fNRmTmn9K5SYCmyyohMGL Is8Ehi32+jynmsJDIDlZKOasC4O+sguZJaBlB8vZ6WvQRcwjx25uhxIoYvdJGXJJov/ajeZ+QuMjS aC44BLmP4H1KVkZFf9y/9/Xo4DM+ep+uUOj8iC17whWSJV4deYQSH7CRgv7cvQgIFbrcpxCVh2hVN hGFsrE6ISKkmLWNwBJ5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu9vb-0035WG-Ri; Mon, 06 Dec 2021 09:04:56 +0000 Received: from mx4.securetransport.de ([178.254.6.145]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mu9vW-0035U2-Kv for linux-arm-kernel@lists.infradead.org; Mon, 06 Dec 2021 09:04:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1638781458; bh=7QTHPEj3xId1e9VWnz2SPGKhd6e31sms4WzmISnvCSI=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=PRd7IbdIMkP/CAqqr9PgeTZPpbvqqjqOn3nsIKacGVOcLwJ+sCgvdY2axbxQAGuqy WMIScb3wN2GqwV+1OqR/C1ZDlNYGPeaENOp8O38xe4Y9xDQE4CwWsXpDeEcKF3az5D DB4seEmXQm0Q3Cb22rRzm+S+y2XaVQs+X2Kema5HYzNUc8BW7DB5/VHk4oS1guDkNV lTKDFvL3nSwe/Kj8HHfJYFY9kYuNjdvZDjkVUgTt3/XQhL1hIUkSqGfRY7RhQm87kL zs7psMMPTa8ok76KnSESQWX0w5e6bW0s1pEXlT/44uaQqomZsupiF3vGhS4zUp/jWY wC78lcjZ2OqNg== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Andrej Picej , "support.opensource@diasemi.com" , "linux@roeck-us.net" , "linux-watchdog@vger.kernel.org" CC: "wim@linux-watchdog.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-imx@nxp.com" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v5 3/5] watchdog: da9062: reset board on watchdog timeout Thread-Topic: [PATCH v5 3/5] watchdog: da9062: reset board on watchdog timeout Thread-Index: AQHX6m0ssYFzMVsGKUOej/p+k31dD6wlJszQ Date: Mon, 6 Dec 2021 08:49:06 +0000 Message-ID: <45ba492664c8401494bd8d047e1fb1f2@dh-electronics.com> References: <20211206064732.280375-1-andrej.picej@norik.com> <20211206064732.280375-3-andrej.picej@norik.com> In-Reply-To: <20211206064732.280375-3-andrej.picej@norik.com> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_010451_059061_8E4CF03A X-CRM114-Status: GOOD ( 25.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Andrej Picej Sent: Monday, December 6, 2021 7:48 AM > Implement a method to change watchdog timeout configuration based on DT > binding ("dlg,wdt-sd"). There is a possibility to change the behaviour > of watchdog reset. Setting WATCHDOG_SD bit enables SHUTDOWN mode, and > clearing it enables POWERDOWN mode on watchdog timeout. > > If no DT binding is specified the WATCHDOG_SD bit stays in default > configuration, not breaking behaviour of devices which might depend on > default fuse configuration. > > Note: This patch requires that the config register CONFIG_I is > configured as writable in the da9061/2 multi function device. > > Signed-off-by: Andrej Picej > --- > Changes in v5: > - fix spelling mistake in commit message > > Changes in v4: > - move the code to probe function > > Changes in v3: > - no changes > > Changes in v2: > - don't force the "reset" for all da9062-watchdog users, instead add DT > binding where the behavior can be selected > --- > drivers/watchdog/da9062_wdt.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.c > index f02cbd530538..bd85f84b0fd4 100644 > --- a/drivers/watchdog/da9062_wdt.c > +++ b/drivers/watchdog/da9062_wdt.c > @@ -195,8 +195,11 @@ static int da9062_wdt_probe(struct platform_device > *pdev) > { > struct device *dev = &pdev->dev; > unsigned int timeout; > + unsigned int mask; > struct da9062 *chip; > struct da9062_watchdog *wdt; > + int ret; > + u32 val; > > chip = dev_get_drvdata(dev->parent); > if (!chip) > @@ -236,6 +239,30 @@ static int da9062_wdt_probe(struct platform_device > *pdev) > set_bit(WDOG_HW_RUNNING, &wdt->wdtdev.status); > } > > + /* > + * Configure what happens on watchdog timeout. Can be specified with > + * "dlg,wdt-sd" dt-binding (0 -> POWERDOWN, 1 -> SHUTDOWN). > + * If "dlg,wdt-sd" dt-binding is NOT set use the default. > + */ > + ret = device_property_read_u32(dev, "dlg,wdt-sd", &val); > + if (!ret) { > + if (val) > + /* Use da9062's SHUTDOWN mode */ > + mask = DA9062AA_WATCHDOG_SD_MASK; > + else > + /* Use da9062's POWERDOWN mode. */ > + mask = 0x0; > + > + ret = regmap_update_bits(wdt->hw->regmap, > + DA9062AA_CONFIG_I, > + DA9062AA_WATCHDOG_SD_MASK, > + mask); > + > + if (ret) > + dev_err(dev, "failed to set wdt reset mode: %d\n", > + ret); > + } > + > return devm_watchdog_register_device(dev, &wdt->wdtdev); > } > > -- > 2.25.1 Tested-by: Christoph Niedermaier Thanks and regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel