From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06635CCA479 for ; Tue, 28 Jun 2022 04:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231565AbiF1EGf (ORCPT ); Tue, 28 Jun 2022 00:06:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230435AbiF1EGe (ORCPT ); Tue, 28 Jun 2022 00:06:34 -0400 Received: from m1550.mail.126.com (m1550.mail.126.com [220.181.15.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 823F92C119; Mon, 27 Jun 2022 21:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=XWeHT AWwOqeIwM0omsKO9lmRWk4etNQ5KQlcaSVkBdU=; b=mAwf6Q0zU1m5++ke0dgEN NpPj2G9FjnZxtPGf/1cMKj2qHoctUf1PPmzyXSvhr9mtW9+ZBb8+HEbnsn95nbdt DV7mGnH6eTd9Ld9N+vTtg9kTmT/3XNM37ngEYT1waUswukHpyKfwiUeT40t+JcAC qhz2SI3K33qwCe41cXIHEE= Received: from windhl$126.com ( [124.16.139.61] ) by ajax-webmail-wmsvr50 (Coremail) ; Tue, 28 Jun 2022 12:05:45 +0800 (CST) X-Originating-IP: [124.16.139.61] Date: Tue, 28 Jun 2022 12:05:45 +0800 (CST) From: "Liang He" To: "Tony Lindgren" Cc: andre.przywara@arm.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, "Krzysztof Kozlowski" Subject: Re:Re: [PATCH] arm/mach: Hold reference returned by of_find_xxx APIs X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20220113(9671e152) Copyright (c) 2002-2022 www.mailtech.cn 126com In-Reply-To: References: <20220621091937.4082422-1-windhl@126.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=GBK MIME-Version: 1.0 Message-ID: <45bb4c11.34fc.181a87c93dd.Coremail.windhl@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: MsqowACn9fEafrpiDOY+AA--.21859W X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbizhcuF18RPY+UrwADsk X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org CgoKCgpBdCAyMDIyLTA2LTI4IDExOjU5OjQ1LCAiVG9ueSBMaW5kZ3JlbiIgPHRvbnlAYXRvbWlk ZS5jb20+IHdyb3RlOgo+KiBMaWFuZyBIZSA8d2luZGhsQDEyNi5jb20+IFsyMjA2MjEgMTI6MTRd Ogo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm0vbWFjaC1vbWFwMi9wbWljLWNwY2FwLmMgYi9hcmNo L2FybS9tYWNoLW9tYXAyL3BtaWMtY3BjYXAuYwo+PiBpbmRleCA2NjhkYzg0ZmQzMWUuLmE3MzY4 ZDY1N2FhOCAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm0vbWFjaC1vbWFwMi9wbWljLWNwY2FwLmMK Pj4gKysrIGIvYXJjaC9hcm0vbWFjaC1vbWFwMi9wbWljLWNwY2FwLmMKPj4gQEAgLTIzOCw4ICsy MzgsMTEgQEAgc3RhdGljIHN0cnVjdCBvbWFwX3ZvbHRkbV9wbWljIG9tYXA0X2Zhbl9pdmEgPSB7 Cj4+ICBpbnQgX19pbml0IG9tYXA0X2NwY2FwX2luaXQodm9pZCkKPj4gIHsKPj4gIAlzdHJ1Y3Qg dm9sdGFnZWRvbWFpbiAqdm9sdGRtOwo+PiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnA7Cj4+ICAK Pj4gLQlpZiAoIW9mX2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsICJtb3Rvcm9sYSxj cGNhcCIpKQo+PiArCW5wID0gb2ZfZmluZF9jb21wYXRpYmxlX25vZGUoTlVMTCwgTlVMTCwgIm1v dG9yb2xhLGNwY2FwIik7Cj4+ICsJb2Zfbm9kZV9wdXQobnApOwo+PiArCWlmICghbnApCj4+ICAJ CXJldHVybiAtRU5PREVWOwo+Cj5IbW0gc28gaGVyZSB5b3UgYXJlIGNoZWNraW5nIGZvciAhbnAg YWZ0ZXIgb2Zfbm9kZV9wdXQoKT8KCkhpLCBUb255LgoKVGhhbmtzIHZlcnkgbXVjaCBmb3IgeW91 ciBlZmZvcnQgdG8gcmV2aWV3IG15IGNvZGUuCgpJIGp1c3Qgd2FudGVkIHRvIHVzZSB0aGlzICdj aGVjay1hZnRlci1wdXQnIGNvZGluZyBzdHlsZSB0byBrZWVwIGNvbnNpc3RlbnQgd2l0aApleGlz dGluZyBzdHlsZS4gCgpCdXQgYmFzZWQgb24gdGhlIGRpc2NjdXNzaW9uIHdpdGggR3JlZyBLSCwg eWVzdGVyZGF5LCBJIGFtIG5vdyBwcmVwYXJpbmcgJ2NoZWNrLXRoZW4tcHV0JyAKY29kaW5nIHN0 eWxlIHBhdGNoLgoKTGluazogCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8xYmVkMDZlNS40 M2RhLjE4MWE1YmFjN2U1LkNvcmVtYWlsLndpbmRobEAxMjYuY29tLwoKPgo+PiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm0vbWFjaC10ZWdyYS9pcnEuYyBiL2FyY2gvYXJtL21hY2gtdGVncmEvaXJxLmMK Pj4gaW5kZXggNGUxZWU3MGIyYTNmLi4yYWVhYzA0MWJjYjkgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gv YXJtL21hY2gtdGVncmEvaXJxLmMKPj4gKysrIGIvYXJjaC9hcm0vbWFjaC10ZWdyYS9pcnEuYwo+ PiBAQCAtODgsNyArODgsMTEgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgdGVn cmFfaWN0bHJfbWF0Y2hbXSBfX2luaXRjb25zdCA9IHsKPj4gIAo+PiAgdm9pZCBfX2luaXQgdGVn cmFfaW5pdF9pcnEodm9pZCkKPj4gIHsKPj4gLQlpZiAoV0FSTl9PTighb2ZfZmluZF9tYXRjaGlu Z19ub2RlKE5VTEwsIHRlZ3JhX2ljdGxyX21hdGNoKSkpCj4+ICsJc3RydWN0IGRldmljZV9ub2Rl ICpucDsKPj4gKwo+PiArCW5wID0gb2ZfZmluZF9tYXRjaGluZ19ub2RlKE5VTEwsIHRlZ3JhX2lj dGxyX21hdGNoKTsKPj4gKwlvZl9ub2RlX3B1dChucCk7Cj4+ICsJaWYgKFdBUk5fT04oIW5wKSkK Pj4gIAkJcHJfd2FybigiT3V0ZGF0ZWQgRFQgZGV0ZWN0ZWQsIHN1c3BlbmQvcmVzdW1lIHdpbGwg Tk9UIHdvcmtcbiIpOwo+PiAgCj4+ICAJdGVncmExMTRfZ2ljX2NwdV9wbV9yZWdpc3RyYXRpb24o KTsKPgo+SGVyZSB0b28uCj4KPlJlZ2FyZHMsCj4KPlRvbnkKClRoYW5rcyBhZ2FpbiwgVG9ueS4K Ckkgd2lsbCBzZW5kIGEgbmV3ICdjaGVjay1hbmQtcHV0JyBwYXRjaCBzb29uLgoKTGlhbmcK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03233C43334 for ; Tue, 28 Jun 2022 04:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n5Bi2uIabxzgdKbibYj6e7BWpXZRHDswWgEwN2kIFrI=; b=FwfknLukxzePYF eqlp21dYa5vUccCp+pB7QnPPnn5ZSM5xEJNHYAt9k0Oua2ibGrmV3Zo6kvvS9jY4v9ZU7fEnAO3Mc 95cz6/inr8QUDPoSTv4Nl+qDed+jjiMuakvghHxipQ6egkFFbd+rKpSNsHttMTyWKmISI0frxnlkP pOPkP9Ra0Gx8IpT7z6wfWv61J60XQM3vKwNFdVrLHYVZsvetSHJtDuSRBpUDXnPutihDheQKkRITY 2Fh2Vu1V1/IpKYnCtKGfHdrVdaFcS03pS3aYM6eY01G3L0srCpTs7urcOKN7yQN2KH69j2n+6zJpo m+Ap4cQV5ec+bmY4pTSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o62Ua-0047jK-V7; Tue, 28 Jun 2022 04:06:25 +0000 Received: from m1550.mail.126.com ([220.181.15.50]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o62UW-0047gW-Tr for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 04:06:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=XWeHT AWwOqeIwM0omsKO9lmRWk4etNQ5KQlcaSVkBdU=; b=mAwf6Q0zU1m5++ke0dgEN NpPj2G9FjnZxtPGf/1cMKj2qHoctUf1PPmzyXSvhr9mtW9+ZBb8+HEbnsn95nbdt DV7mGnH6eTd9Ld9N+vTtg9kTmT/3XNM37ngEYT1waUswukHpyKfwiUeT40t+JcAC qhz2SI3K33qwCe41cXIHEE= Received: from windhl$126.com ( [124.16.139.61] ) by ajax-webmail-wmsvr50 (Coremail) ; Tue, 28 Jun 2022 12:05:45 +0800 (CST) X-Originating-IP: [124.16.139.61] Date: Tue, 28 Jun 2022 12:05:45 +0800 (CST) From: "Liang He" To: "Tony Lindgren" Cc: andre.przywara@arm.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, "Krzysztof Kozlowski" Subject: Re:Re: [PATCH] arm/mach: Hold reference returned by of_find_xxx APIs X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20220113(9671e152) Copyright (c) 2002-2022 www.mailtech.cn 126com In-Reply-To: References: <20220621091937.4082422-1-windhl@126.com> MIME-Version: 1.0 Message-ID: <45bb4c11.34fc.181a87c93dd.Coremail.windhl@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: MsqowACn9fEafrpiDOY+AA--.21859W X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbizhcuF18RPY+UrwADsk X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220627_210621_369314_F9FD1D31 X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org At 2022-06-28 11:59:45, "Tony Lindgren" wrote: >* Liang He [220621 12:14]: >> diff --git a/arch/arm/mach-omap2/pmic-cpcap.c b/arch/arm/mach-omap2/pmic-cpcap.c >> index 668dc84fd31e..a7368d657aa8 100644 >> --- a/arch/arm/mach-omap2/pmic-cpcap.c >> +++ b/arch/arm/mach-omap2/pmic-cpcap.c >> @@ -238,8 +238,11 @@ static struct omap_voltdm_pmic omap4_fan_iva = { >> int __init omap4_cpcap_init(void) >> { >> struct voltagedomain *voltdm; >> + struct device_node *np; >> >> - if (!of_find_compatible_node(NULL, NULL, "motorola,cpcap")) >> + np = of_find_compatible_node(NULL, NULL, "motorola,cpcap"); >> + of_node_put(np); >> + if (!np) >> return -ENODEV; > >Hmm so here you are checking for !np after of_node_put()? Hi, Tony. Thanks very much for your effort to review my code. I just wanted to use this 'check-after-put' coding style to keep consistent with existing style. But based on the disccussion with Greg KH, yesterday, I am now preparing 'check-then-put' coding style patch. Link: https://lore.kernel.org/all/1bed06e5.43da.181a5bac7e5.Coremail.windhl@126.com/ > >> diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c >> index 4e1ee70b2a3f..2aeac041bcb9 100644 >> --- a/arch/arm/mach-tegra/irq.c >> +++ b/arch/arm/mach-tegra/irq.c >> @@ -88,7 +88,11 @@ static const struct of_device_id tegra_ictlr_match[] __initconst = { >> >> void __init tegra_init_irq(void) >> { >> - if (WARN_ON(!of_find_matching_node(NULL, tegra_ictlr_match))) >> + struct device_node *np; >> + >> + np = of_find_matching_node(NULL, tegra_ictlr_match); >> + of_node_put(np); >> + if (WARN_ON(!np)) >> pr_warn("Outdated DT detected, suspend/resume will NOT work\n"); >> >> tegra114_gic_cpu_pm_registration(); > >Here too. > >Regards, > >Tony Thanks again, Tony. I will send a new 'check-and-put' patch soon. Liang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel