All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Hao Xu <howeyxu@tencent.com>,
	Pavel Begunkov <asml.silence@gmail.com>,
	Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
	Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>,
	GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
	io-uring Mailing List <io-uring@vger.kernel.org>
Subject: [RFC liburing for-2.3] Kill src/syscall.c
Date: Mon, 11 Jul 2022 16:23:56 +0700	[thread overview]
Message-ID: <45d0409e-e112-a0e9-7007-9db34d53a43f@gnuweeb.org> (raw)


Hi Jens,

I haven't written any patch, but I want to get your comments first.
If you think it's a good idea, I will wire up a patch.

## Background story:

Since we support nolibc, the file src/syscall.c is no longer used by
any liburing internal functions. It's only used by `test/`.

Other architectures that still depend on libc are now using:

     src/generic/syscall.h

*not*:

     src/syscall.c

I should have killed src/syscall.c and fixed the tests earlier when
adding nolibc support, unfortunately, I didn't. I was mistaken that
if we killed src/syscall.c, it might break user. But no, no user uses
it.

We don't actually intend to export __sys_io_uring* functions to user.
This situation is reflected in liburing.map and liburing.h which don't
have those functions.

## Proposal:

Let's just kill src/syscall.c and use __sys_io_uring* or
____sys_io_uring* only.


## Two choices:

1. Keep using ____sys_io_uring* functions and delete __sys_io_uring*
    functions.

2. Back to use __sys_io_uring* functions and delete ____sys_io_uring*.

Both choices need to fix tests. I can do that. I personally like the
second choice since we don't have many underscores.

What do you think?

-- 
Ammar Faizi


                 reply	other threads:[~2022-07-11  9:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45d0409e-e112-a0e9-7007-9db34d53a43f@gnuweeb.org \
    --to=ammarfaizi2@gnuweeb.org \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=fernandafmr12@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=howeyxu@tencent.com \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.