From: Sinan Kaya <okaya@kernel.org>
To: Huacai Chen <chenhc@lemote.com>, Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Tiezhu Yang <yangtiezhu@loongson.cn>
Subject: Re: [PATCH] PCI/portdrv: Don't disable pci device during shutdown
Date: Mon, 21 Sep 2020 11:50:51 -0400 [thread overview]
Message-ID: <45e7272c-e074-d894-9319-ee29f451f282@kernel.org> (raw)
In-Reply-To: <1600680138-10949-1-git-send-email-chenhc@lemote.com>
On 9/21/2020 5:22 AM, Huacai Chen wrote:
> Use separate remove()/shutdown() callback, and don't disable pci device
> during shutdown. This can avoid some poweroff/reboot failures.
>
> The poweroff/reboot failures can easily reproduce on Loongson platforms.
> I think this is not a Loongson-specific problem, instead, is a problem
> related to some specific PCI hosts. On some x86 platforms, radeon/amdgpu
> devices can cause the same problem, and commit faefba95c9e8ca3a523831c2e
> ("drm/amdgpu: just suspend the hw on pci shutdown") can resolve it.
This sounds like a quirk to me rather than a behavior that should be
applied to all platforms.
next prev parent reply other threads:[~2020-09-21 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 9:22 [PATCH] PCI/portdrv: Don't disable pci device during shutdown Huacai Chen
2020-09-21 15:50 ` Sinan Kaya [this message]
2020-09-22 2:11 ` Huacai Chen
2020-09-22 4:30 ` Sinan Kaya
2020-09-22 6:20 ` Tiezhu Yang
2020-09-22 6:16 ` Huacai Chen
2020-12-31 6:15 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45e7272c-e074-d894-9319-ee29f451f282@kernel.org \
--to=okaya@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-pci@vger.kernel.org \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.