From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clg@kaod.org>) id 1bta8D-0001se-TJ
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 08:56:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clg@kaod.org>) id 1bta88-0008Vn-Uh
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 08:56:36 -0400
Received: from 14.mo1.mail-out.ovh.net ([178.32.97.215]:34009)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <clg@kaod.org>)
	id 1bta88-0008VV-Oq
	for qemu-devel@nongnu.org; Mon, 10 Oct 2016 08:56:32 -0400
Received: from player726.ha.ovh.net (b7.ovh.net [213.186.33.57])
	by mo1.mail-out.ovh.net (Postfix) with ESMTP id EC4741354A
	for <qemu-devel@nongnu.org>; Mon, 10 Oct 2016 14:56:30 +0200 (CEST)
References: <1475479496-16158-1-git-send-email-clg@kaod.org>
	<1475479496-16158-4-git-send-email-clg@kaod.org>
	<20161007043221.GS18490@umbus.fritz.box>
From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clg@kaod.org>
Message-ID: <45ecd367-07ce-e143-cf53-e7332cc94ac2@kaod.org>
Date: Mon, 10 Oct 2016 14:56:25 +0200
MIME-Version: 1.0
In-Reply-To: <20161007043221.GS18490@umbus.fritz.box>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 03/20] ppc/pnv: add a core mask to
 PnvChip
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>, qemu-devel@nongnu.org


>> @@ -227,11 +227,44 @@ static void ppc_powernv_init(MachineState *machine)
>>          snprintf(chip_name, sizeof(chip_name), "chip[%d]", CHIP_HWID(i));
>>          object_property_add_child(OBJECT(pnv), chip_name, chip, &error_fatal);
>>          object_property_set_int(chip, CHIP_HWID(i), "chip-id", &error_fatal);
>> +        object_property_set_int(chip, smp_cores, "nr-cores", &error_fatal);
>> +        /*
>> +         * We could customize cores_mask for the chip here. May be
>> +         * using a powernv machine property, like 'num-chips'. Let the
>> +         * chip choose the default for now.
> 
> I don't think you need any special mechanism for this.  If you just
> remove this explicit assignment the chip default will apply, but the
> user can alter it using -global.

Using a command line with :

	-global powernv-chip-POWER8.cores-mask=0x7070

would work for one chip but not for more. Let's start with that, I will 
remove the comment for now. multiple chip is for later.

Thanks,

C.