From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE303C5478C for ; Fri, 1 Mar 2024 09:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O7Fvgf6YFEc5TmcrYcoD+9PXyen2HrvEbRiuGpGoFEk=; b=UODfai/H+SQPvmVOS+YKiFF4Tt ytZiEAGAE1gjLRLQzmDS3jBa63v70L48kwzl3CzT3Fnu8xk1hsh8epK/GQF4f8768kIs0geO+aGLW xPnyhODp3E9ak2GTujHlmyAdLQTFWGO13ZHqIaBuce6biMAHi9V32DZUTPIW5cAsI0Jqseeq4A45F xENCDnb+qfO42ScH4vboNsSgwfIy0dxUp0yOWAt487wguy3wHB+vrLX0VBUjTY6QgR7DfOEwWYzf4 aVKjL58+YH/UBNDwlQjwwViVU52laxNdV1bk4ABzYRDo7b9kINohU5XQAPPQN8JXNTxAaKrJlM6a6 tEbm7XbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfzG5-0000000HBai-0EAN; Fri, 01 Mar 2024 09:32:49 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfzG2-0000000HBZK-1D3j; Fri, 01 Mar 2024 09:32:47 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709285564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xWnCAqlRky59uzjgS2pvvw8UDh0s4NIkuKC9sP6iSjQ=; b=fZoVZco/LUMLOlBuONfLUCRLh+wagOo3Ww6wG7ahhpmduuxyVjk/j2fYLtIT1XAhZ/U9BM 9+lw44/haRw7Dqzn7MWn7C/KPCbTq0rPOjdXN+S9B3LbxTVMtochpLyxjKUS9cFIDkaUvI FUvhkZpgD1UhcavQoSbJon8jUFYmVscsqWZXAqgi25iSnf87TB0ncW89L4BigG3MFsvzDA mXFNOSBNJbAuakQCMrB0sKM9tzOd5jDV/Wpm4IA7amOtF4T2xH4lvdbEPEjn4ykjoUoYDS e1Z2vwOY3R55GgvhU7WROc2N5hBd4X2Uf7XDty6+LQO7vePZq/qBgszUDuh4RQ== Date: Fri, 01 Mar 2024 10:32:43 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] arm64: dts: rockchip: enable automatic active cooling on Rock 5B In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-2-6afe8473a631@gmail.com> <823379825559bb76088c31f44f998dd3@manjaro.org> Message-ID: <45f5c18094d9e2f8861c5d9ff37ad124@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_013246_498600_65971230 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAwOTozMCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gRnJpLCBNYXIg MSwgMjAyNCBhdCAxMjoyNeKAr1BNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiAK PiB3cm90ZToKPj4gT24gMjAyNC0wMy0wMSAwNzoxNywgRHJhZ2FuIFNpbWljIHdyb3RlOgo+PiA+ IE9uIDIwMjQtMDMtMDEgMDY6MjEsIEFsZXhleSBDaGFya292IHdyb3RlOgo+PiA+PiBPbiBGcmks IE1hciAxLCAyMDI0IGF0IDE6MjXigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9y Zz4KPj4gPj4gd3JvdGU6Cj4+ID4+PiBPbiAyMDI0LTAyLTI5IDIwOjI2LCBBbGV4ZXkgQ2hhcmtv diB3cm90ZToKPj4gPj4+ID4gVGhpcyBsaW5rcyB0aGUgUFdNIGZhbiBvbiBSYWR4YSBSb2NrIDVC IGFzIGFuIGFjdGl2ZSBjb29saW5nIGRldmljZQo+PiA+Pj4gPiBtYW5hZ2VkIGF1dG9tYXRpY2Fs bHkgYnkgdGhlIHRoZXJtYWwgc3Vic3lzdGVtLCB3aXRoIGEgdGFyZ2V0IFNvQwo+PiA+Pj4gPiB0 ZW1wZXJhdHVyZSBvZiA2NUMgYW5kIGEgbWluaW11bS1zcGluIGludGVydmFsIGZyb20gNTVDIHRv IDY1QyB0bwo+PiA+Pj4gPiBlbnN1cmUgYWlyZmxvdyB3aGVuIHRoZSBzeXN0ZW0gZ2V0cyB3YXJt Cj4+ID4+Pgo+PiA+Pj4gSSdkIHN1Z2dlc3QgdGhhdCB5b3UgcmVwbGFjZSAiYXV0b21hdGljIGFj dGl2ZSBjb29saW5nIiB3aXRoICJhY3RpdmUKPj4gPj4+IGNvb2xpbmciIGluIHRoZSBwYXRjaCBz dWJqZWN0LiAgSSBrbm93LCBpdCBtYXkgc2VlbSBsaWtlIG1vcmUgb2YgdGhlCj4+ID4+PiB1bm5l Y2Vzc2FyeSBuaXRwaWNraW5nLCA6KSBidXQgSSBob3BlIHlvdSdsbCBhZ3JlZSB0aGF0ICJhdXRv bWF0aWMiCj4+ID4+PiBpcyBhY3R1YWxseSByZWR1bmRhbnQgdGhlcmUuICBJdCB3b3VsZCBhbHNv IG1ha2UgdGhlIHBhdGNoIHN1YmplY3QKPj4gPj4+IGEgYml0IHNob3J0ZXIuCj4+ID4+Pgo+PiA+ Pj4gQW5vdGhlciBvcHRpb24gd291bGQgYmUgdG8gcmVwbGFjZSAiYXV0b21hdGljIGFjdGl2ZSBj b29saW5nIiB3aXRoCj4+ID4+PiAiYXV0b21hdGljIGZhbiBjb250cm9sIiwgd2hpY2ggbWF5IGFj dHVhbGx5IGJlIGEgYmV0dGVyIGNob2ljZS4KPj4gPj4+IEknZCBiZSBoYXBweSB3aXRoIHdoaWNo ZXZlciBvbmUgeW91IHByZWZlci4gOikKPj4gPj4KPj4gPj4gU291bmRzIGdvb2QgdG8gbWUsIHRo YW5rcyEKPj4gPgo+PiA+IEknbSBnbGFkIHRoYXQgeW91IGxpa2UgaXQuIDopCj4+ID4KPj4gPj4+ IE90aGVyd2lzZSwgcGxlYXNlIGZlZWwgZnJlZSB0byBhZGQ6Cj4+ID4+Pgo+PiA+Pj4gUmV2aWV3 ZWQtYnk6IERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPgo+PiA+Pgo+PiA+PiBUaGFu ayB5b3UgRHJhZ2FuLCBtdWNoIGFwcHJlY2lhdGVkIQo+PiA+Cj4+ID4gVGhhbmsgeW91IGZvciBw dXR0aW5nIHVwIHdpdGggbXkgbml0cGlja2luZy4gOikKPj4gCj4+IFBlcmhhcHMgdGhlIGZvbGxv d2luZyB0YWcgd291bGQgYWxzbyBiZSBkZXNlcnZlZCBmb3IgdGhpcyBwYXRjaDoKPj4gCj4+IEhl bHBlZC1ieTogRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+Cj4+IAo+PiBJIGhvcGUg eW91IGFncmVlLiA6KQo+IAo+IERlZmluaXRlbHkhIFRoYW5rcyBhZ2FpbiBmb3IgeW91ciBmZWVk YmFjayBhbmQgY29udHJpYnV0aW9uIQoKSSdtIGdsYWQgdG8gaGVscC4gOikKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA3C8C5475B for ; Fri, 1 Mar 2024 09:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=smTkaZbru+YpYqm3rcBJUOigylXHo/E+Th/hCNmsFzQ=; b=xo1Ms3bOsCxZKophHQdSpkmJo0 H9ApegYh0Q5nqQdDBC8NNrAu2QG176K3AkDEpmb34Q4skjLAX1me1gNC//3rWxyk6WAUDngCuRCX6 +rIuxdVd6MY2LmhwOC+hbt6wpbbtEO0YIyQbKAW0vTMdmIADNHTJ5E+CkgNGFFuT0YDTkhSgo+W0o pGwTqEFGsL1a8NiscXmdmzpTIsg9nt7TFPlsitCzK6QBooJMONokSaOp+rUl2Yk0oO8bDvSc4iNf6 nWcKJkmJ7rTKwTnSDlk+S6OJznEJf6SgoHAFYixAi9hecuPJ8DLz0NcWlpEHaaeSV1kqDBMfGeM/s WefNxlyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfzG4-0000000HBaN-21k5; Fri, 01 Mar 2024 09:32:48 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfzG2-0000000HBZK-1D3j; Fri, 01 Mar 2024 09:32:47 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709285564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xWnCAqlRky59uzjgS2pvvw8UDh0s4NIkuKC9sP6iSjQ=; b=fZoVZco/LUMLOlBuONfLUCRLh+wagOo3Ww6wG7ahhpmduuxyVjk/j2fYLtIT1XAhZ/U9BM 9+lw44/haRw7Dqzn7MWn7C/KPCbTq0rPOjdXN+S9B3LbxTVMtochpLyxjKUS9cFIDkaUvI FUvhkZpgD1UhcavQoSbJon8jUFYmVscsqWZXAqgi25iSnf87TB0ncW89L4BigG3MFsvzDA mXFNOSBNJbAuakQCMrB0sKM9tzOd5jDV/Wpm4IA7amOtF4T2xH4lvdbEPEjn4ykjoUoYDS e1Z2vwOY3R55GgvhU7WROc2N5hBd4X2Uf7XDty6+LQO7vePZq/qBgszUDuh4RQ== Date: Fri, 01 Mar 2024 10:32:43 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] arm64: dts: rockchip: enable automatic active cooling on Rock 5B In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-2-6afe8473a631@gmail.com> <823379825559bb76088c31f44f998dd3@manjaro.org> Message-ID: <45f5c18094d9e2f8861c5d9ff37ad124@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_013246_498600_65971230 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAwOTozMCwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4gT24gRnJpLCBNYXIg MSwgMjAyNCBhdCAxMjoyNeKAr1BNIERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPiAK PiB3cm90ZToKPj4gT24gMjAyNC0wMy0wMSAwNzoxNywgRHJhZ2FuIFNpbWljIHdyb3RlOgo+PiA+ IE9uIDIwMjQtMDMtMDEgMDY6MjEsIEFsZXhleSBDaGFya292IHdyb3RlOgo+PiA+PiBPbiBGcmks IE1hciAxLCAyMDI0IGF0IDE6MjXigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9y Zz4KPj4gPj4gd3JvdGU6Cj4+ID4+PiBPbiAyMDI0LTAyLTI5IDIwOjI2LCBBbGV4ZXkgQ2hhcmtv diB3cm90ZToKPj4gPj4+ID4gVGhpcyBsaW5rcyB0aGUgUFdNIGZhbiBvbiBSYWR4YSBSb2NrIDVC IGFzIGFuIGFjdGl2ZSBjb29saW5nIGRldmljZQo+PiA+Pj4gPiBtYW5hZ2VkIGF1dG9tYXRpY2Fs bHkgYnkgdGhlIHRoZXJtYWwgc3Vic3lzdGVtLCB3aXRoIGEgdGFyZ2V0IFNvQwo+PiA+Pj4gPiB0 ZW1wZXJhdHVyZSBvZiA2NUMgYW5kIGEgbWluaW11bS1zcGluIGludGVydmFsIGZyb20gNTVDIHRv IDY1QyB0bwo+PiA+Pj4gPiBlbnN1cmUgYWlyZmxvdyB3aGVuIHRoZSBzeXN0ZW0gZ2V0cyB3YXJt Cj4+ID4+Pgo+PiA+Pj4gSSdkIHN1Z2dlc3QgdGhhdCB5b3UgcmVwbGFjZSAiYXV0b21hdGljIGFj dGl2ZSBjb29saW5nIiB3aXRoICJhY3RpdmUKPj4gPj4+IGNvb2xpbmciIGluIHRoZSBwYXRjaCBz dWJqZWN0LiAgSSBrbm93LCBpdCBtYXkgc2VlbSBsaWtlIG1vcmUgb2YgdGhlCj4+ID4+PiB1bm5l Y2Vzc2FyeSBuaXRwaWNraW5nLCA6KSBidXQgSSBob3BlIHlvdSdsbCBhZ3JlZSB0aGF0ICJhdXRv bWF0aWMiCj4+ID4+PiBpcyBhY3R1YWxseSByZWR1bmRhbnQgdGhlcmUuICBJdCB3b3VsZCBhbHNv IG1ha2UgdGhlIHBhdGNoIHN1YmplY3QKPj4gPj4+IGEgYml0IHNob3J0ZXIuCj4+ID4+Pgo+PiA+ Pj4gQW5vdGhlciBvcHRpb24gd291bGQgYmUgdG8gcmVwbGFjZSAiYXV0b21hdGljIGFjdGl2ZSBj b29saW5nIiB3aXRoCj4+ID4+PiAiYXV0b21hdGljIGZhbiBjb250cm9sIiwgd2hpY2ggbWF5IGFj dHVhbGx5IGJlIGEgYmV0dGVyIGNob2ljZS4KPj4gPj4+IEknZCBiZSBoYXBweSB3aXRoIHdoaWNo ZXZlciBvbmUgeW91IHByZWZlci4gOikKPj4gPj4KPj4gPj4gU291bmRzIGdvb2QgdG8gbWUsIHRo YW5rcyEKPj4gPgo+PiA+IEknbSBnbGFkIHRoYXQgeW91IGxpa2UgaXQuIDopCj4+ID4KPj4gPj4+ IE90aGVyd2lzZSwgcGxlYXNlIGZlZWwgZnJlZSB0byBhZGQ6Cj4+ID4+Pgo+PiA+Pj4gUmV2aWV3 ZWQtYnk6IERyYWdhbiBTaW1pYyA8ZHNpbWljQG1hbmphcm8ub3JnPgo+PiA+Pgo+PiA+PiBUaGFu ayB5b3UgRHJhZ2FuLCBtdWNoIGFwcHJlY2lhdGVkIQo+PiA+Cj4+ID4gVGhhbmsgeW91IGZvciBw dXR0aW5nIHVwIHdpdGggbXkgbml0cGlja2luZy4gOikKPj4gCj4+IFBlcmhhcHMgdGhlIGZvbGxv d2luZyB0YWcgd291bGQgYWxzbyBiZSBkZXNlcnZlZCBmb3IgdGhpcyBwYXRjaDoKPj4gCj4+IEhl bHBlZC1ieTogRHJhZ2FuIFNpbWljIDxkc2ltaWNAbWFuamFyby5vcmc+Cj4+IAo+PiBJIGhvcGUg eW91IGFncmVlLiA6KQo+IAo+IERlZmluaXRlbHkhIFRoYW5rcyBhZ2FpbiBmb3IgeW91ciBmZWVk YmFjayBhbmQgY29udHJpYnV0aW9uIQoKSSdtIGdsYWQgdG8gaGVscC4gOikKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872EF69DEA; Fri, 1 Mar 2024 09:32:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709285568; cv=none; b=JjTNNM/pEEv/TrEIp4bHWCdGR+5edy5yimyLNW2jwDtYMlr8Qd7kctu9gSLG1EVlBXRVQnfKnHokcirD5vK2MuSjviCG804pnt+4elLsR3MVrxiEN+nvpY2DrK+aH7t2d8QzSKzGzVTf2DknV9RicVSQO3T/lP6B+Akx52Vxcoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709285568; c=relaxed/simple; bh=DC2Cad3KEwAqbvBLXkQCORcnJPwGKb3sLm5mgUrejMk=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=pbzsnCNUyL5i1MQ+drx38giPSFYjPkqY5kNzltsxu+08MchvnXx4745umWSpJso9rtLAHkReX+Gu9cuHb5ydyis+yKKaWdONsuNDvhXpy9W+HLXQvXr7bKSc3jn/AQMweM8q9iBjvqNRm8yQhZFo2yk/C5pHbzPEBwxcIEBX2qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=fZoVZco/; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="fZoVZco/" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709285564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xWnCAqlRky59uzjgS2pvvw8UDh0s4NIkuKC9sP6iSjQ=; b=fZoVZco/LUMLOlBuONfLUCRLh+wagOo3Ww6wG7ahhpmduuxyVjk/j2fYLtIT1XAhZ/U9BM 9+lw44/haRw7Dqzn7MWn7C/KPCbTq0rPOjdXN+S9B3LbxTVMtochpLyxjKUS9cFIDkaUvI FUvhkZpgD1UhcavQoSbJon8jUFYmVscsqWZXAqgi25iSnf87TB0ncW89L4BigG3MFsvzDA mXFNOSBNJbAuakQCMrB0sKM9tzOd5jDV/Wpm4IA7amOtF4T2xH4lvdbEPEjn4ykjoUoYDS e1Z2vwOY3R55GgvhU7WROc2N5hBd4X2Uf7XDty6+LQO7vePZq/qBgszUDuh4RQ== Date: Fri, 01 Mar 2024 10:32:43 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] arm64: dts: rockchip: enable automatic active cooling on Rock 5B In-Reply-To: References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-2-6afe8473a631@gmail.com> <823379825559bb76088c31f44f998dd3@manjaro.org> Message-ID: <45f5c18094d9e2f8861c5d9ff37ad124@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-03-01 09:30, Alexey Charkov wrote: > On Fri, Mar 1, 2024 at 12:25 PM Dragan Simic > wrote: >> On 2024-03-01 07:17, Dragan Simic wrote: >> > On 2024-03-01 06:21, Alexey Charkov wrote: >> >> On Fri, Mar 1, 2024 at 1:25 AM Dragan Simic >> >> wrote: >> >>> On 2024-02-29 20:26, Alexey Charkov wrote: >> >>> > This links the PWM fan on Radxa Rock 5B as an active cooling device >> >>> > managed automatically by the thermal subsystem, with a target SoC >> >>> > temperature of 65C and a minimum-spin interval from 55C to 65C to >> >>> > ensure airflow when the system gets warm >> >>> >> >>> I'd suggest that you replace "automatic active cooling" with "active >> >>> cooling" in the patch subject. I know, it may seem like more of the >> >>> unnecessary nitpicking, :) but I hope you'll agree that "automatic" >> >>> is actually redundant there. It would also make the patch subject >> >>> a bit shorter. >> >>> >> >>> Another option would be to replace "automatic active cooling" with >> >>> "automatic fan control", which may actually be a better choice. >> >>> I'd be happy with whichever one you prefer. :) >> >> >> >> Sounds good to me, thanks! >> > >> > I'm glad that you like it. :) >> > >> >>> Otherwise, please feel free to add: >> >>> >> >>> Reviewed-by: Dragan Simic >> >> >> >> Thank you Dragan, much appreciated! >> > >> > Thank you for putting up with my nitpicking. :) >> >> Perhaps the following tag would also be deserved for this patch: >> >> Helped-by: Dragan Simic >> >> I hope you agree. :) > > Definitely! Thanks again for your feedback and contribution! I'm glad to help. :)