From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28B93154450; Mon, 6 May 2024 15:50:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715010648; cv=none; b=tiuU2VXbEneRGA42W/5ejfIz0MXxopXgx8ao3zW80XPGFLJBh7pOmUYNLiDE0kxAWrOPR/68dCbV6kes/o9lJB4ulI+N7+Is5hiVwo5ryI9vHG26bmfOcP60FbEHQhAeFt/jLRXiJv+PmJ7Ka5lF+fSBYg8ZzJDzMETCjWdjwEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715010648; c=relaxed/simple; bh=1yyAqDkLFzrqKXzOSJzS2RwxgP/SThZ2l8QRzY3mMto=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HNpMd+ss4nkngeV6fYV5UWp3sh+GBugNEvLfmjijuIjvGa6LIMiZprIbtTwmE+0iiully46DT2ZfGlC6QoW36FNEIxsifhPf+yFVelsDcnYaIBazwbRLIKXcwHp2jx+2TaxUL0p1oAUXwjew3QyLAeIu9YQ+muy+lmhi6CusgqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=P1RfsMEb; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="P1RfsMEb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1715010622; x=1715615422; i=markus.elfring@web.de; bh=H9sTmaUe+r3xoDCrpXo7q1l4R6zgCLudODMODzaJySI=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=P1RfsMEbI6WI5DZVmZCjhlAGG17nCkZrsM2pxE9jgoX6OXUZmXJ1+F2FbJmP+BOt RoWfy9GMi3LIO+fMOy/mPOdh094LVq30Y71TTRGRhZUYFgPxUobApnOFbsB8KYYGx Nn3/SpewE14Us7iAJVv/lbKlSw0N4Pc1kPOsToIZAwpBspM6nAGxEf4lM74eNTgqf bEKo+8O8dS5W/WL4Gg6MXLIQtatqQeh+gcyKCvJ009TchWeW102gKzvzlBDcD8AM+ gLYVxBBu4LcSHDz+VMsRarxP3r82kiucEd+txjQX2VjzEL+dOK7AqGzKWAJyg9bJ8 aPLGTSpouULGIuDh0w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.89.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M5j1c-1rxw3j4AP4-007l9k; Mon, 06 May 2024 17:50:22 +0200 Message-ID: <45f6991d-1595-4ba1-956b-acfcbbdfe8de@web.de> Date: Mon, 6 May 2024 17:50:19 +0200 Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 2/2] ax25: Change kfree() in ax25_dev_free() to ax25_dev_put() To: Dan Carpenter , Duoming Zhou , linux-hams@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , =?UTF-8?Q?J=C3=B6rg_Reuter?= , Paolo Abeni , LKML , Lars Kellogg-Stedman , Simon Horman References: <53925353450dea9a705d67ad225b589e8508042c.1715002910.git.duoming@zju.edu.cn> Content-Language: en-GB From: Markus Elfring In-Reply-To: <53925353450dea9a705d67ad225b589e8508042c.1715002910.git.duoming@zju.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:YbeJ89qqt2nw8KnLHNWF0skZsoHi5qd1kuwRpt0DBunZK4csV0V zWBAkWyR0IcdmCCNgEuexDy+tb8yyZdhHPmgtylpJwBWORJY6SGAlQEIAoOBLDpVl1x+s+w yAd1KRp0oEr9Xx5y6k23CFfq+9wnZ2Wd4oP/RvZzpoZxr0IUbpXd7mlmGIzP9D8mub/PqYd mlo9vzqKRALUIW+QL1inw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IMt04jr/M9U=;H1eGqO+BBW3jUOXk2stzLFN+eog L+RgGRdGcqtQlntEPB9fuk3V1HW0lxR+KgCX1jgBCuOylADU9aOr35dvDYotD16I4BlLIjyqh g4fS6fyyN/jNx3fSQxP5cmA5qgrVmuJCSATNmGuSj1478F4DaUJP/GWyxp49isqDym6G8/qK3 vcqTWngvjCNVfWsodLJ/6GeSKSVu/K1kz4aQodPU1GARlYfm+2WUud1kljw8UQCNlR5lOVU+B 20yanfXneOFYaOFzuLyA6LtAYkEEThQLKhKbYP367CjgmY9Eo4HWzDXCaosBVHQmZgWENExba fz6fXGj2K7h9o1dpFYJPNYL7n+X1cUqyK5q3UBfhXJ95DvAuDRXKo1jubc9uKfCjEzg+QkMMD ttC1OUeRsDbRjp7WZjNzALqc/t3J0zLVan8UQmH8AwYF1pt1UssbL1jodbt4eXVDPohJuMRXy jJOb2U1Pg0wMeRyC7/ThM3czS/phRAfQmiK5AOWf1WM5AvPRD/dvFiXiH05DO2M588FZYFrn+ 0NOlMfNHilJc9vIpzNsmwUGJ2HIMoAs8RKfrzW/v5OXzuIIqt8HOenhh8M84yvhVl6smk6CqB i40J3XF86mqXc3RNuEgi+LN7+aS7lEoSvncWX34djQVC5nC8H5tkbe3ivnXA4jUY08vIFE43y YZS4F/rDy6IrCWUnmiUv7raGxyEi79HUAJc/RZJxY1M8qcV0RJvEItbH88MldXwJagDhxMxty Ss6bFwACuATiotdZtspMPVuDJXXVJGzpTxzn4GP6xsvvSgbD22rTkUhGa8NDA6OeVYMmZr6zM 166wUZOK2Gv+8VFC88m3jx7WWwbOcAAr41GtPz28/BKlo= =E2=80=A6 > Replace it with a ax25_dev_put() call instead. =E2=80=A6 > --- > Changes in v3: > - Make commit messages more clearer. =E2=80=A6 > +++ b/net/ax25/ax25_dev.c > @@ -188,16 +188,13 @@ struct net_device *ax25_fwd_dev(struct net_device = *dev) > */ > void __exit ax25_dev_free(void) > { =E2=80=A6 > - ax25_dev =3D ax25_dev_list; > - while (ax25_dev !=3D NULL) { > - s =3D ax25_dev; > - netdev_put(ax25_dev->dev, &ax25_dev->dev_tracker); > - ax25_dev =3D ax25_dev->next; > - kfree(s); > + list_for_each_entry_safe(s, n, &ax25_dev_list, list) { > + netdev_put(s->dev, &s->dev_tracker); > + list_del(&s->list); > + ax25_dev_put(s); > } > - ax25_dev_list =3D NULL; =E2=80=A6 Can the increased application of the Linux list API be offered as a separate update step? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.9-rc7#n81 Regards, Markus