From: "Christian König" <christian.koenig@amd.com>
To: Benjamin Cheng <benjamin.cheng@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org
Cc: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
Shahyan Soltani <shahyan.soltani@amd.com>
Subject: Re: [PATCH 5/8] drm/amdgpu/userq: remove extra fence request when locking PD
Date: Thu, 19 Nov 2026 14:35:30 +0100 [thread overview]
Message-ID: <45f84bc0-8d9c-44d8-b70b-e188f5fe210b@amd.com> (raw)
In-Reply-To: <20261118185225.1857845-6-benjamin.cheng@amd.com>
On 11/18/26 19:52, Benjamin Cheng wrote:
> These two fences are never used, so just request no fences (lock only).
>
> Signed-off-by: Benjamin Cheng <benjamin.cheng@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> index dd976a50e053..855e521eb201 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> @@ -382,7 +382,7 @@ static int amdgpu_userq_fence_read_wptr(struct amdgpu_device *adev,
>
> drm_exec_init(&exec, DRM_EXEC_IGNORE_DUPLICATES, 2);
> drm_exec_until_all_locked(&exec) {
> - ret = amdgpu_vm_lock_pd(queue->vm, &exec, 1);
> + ret = amdgpu_vm_lock_pd(queue->vm, &exec, 0);
> drm_exec_retry_on_contention(&exec);
> if (unlikely(ret))
> goto lock_error;
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> index 7abb9d95ef59..8b07e21d2686 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> @@ -48,7 +48,7 @@ mes_userq_create_wptr_mapping(struct amdgpu_device *adev,
>
> drm_exec_init(&exec, DRM_EXEC_IGNORE_DUPLICATES, 2);
> drm_exec_until_all_locked(&exec) {
> - ret = amdgpu_vm_lock_pd(vm, &exec, 1);
> + ret = amdgpu_vm_lock_pd(vm, &exec, 0);
> drm_exec_retry_on_contention(&exec);
> if (unlikely(ret))
> goto fail_lock;
next prev parent reply other threads:[~2026-11-19 13:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 18:52 [PATCH 0/8] Consolidate and fix root PD fence resverations Benjamin Cheng
2026-11-18 18:52 ` [PATCH 1/8] drm/amdgpu/vm: reserve more fences in amdgpu_vm_lock_pd Benjamin Cheng
2026-11-19 13:19 ` Christian König
2026-11-18 18:52 ` [PATCH 2/8] drm/amdgpu/dma_buf: reserve AMDGPU_VM_UPDATE_FENCES for move_notify Benjamin Cheng
2026-11-19 13:22 ` Christian König
2026-11-18 18:52 ` [PATCH 3/8] drm/amdgpu/vm: reserve AMDGPU_VM_UPDATE_FENCES for handle_fault Benjamin Cheng
2026-11-19 13:24 ` Christian König
2026-11-18 18:52 ` [PATCH 4/8] drm/amdgpu: reserve only what the caller asks for in lock_pd Benjamin Cheng
2026-11-19 13:27 ` Christian König
2026-11-18 18:52 ` [PATCH 5/8] drm/amdgpu/userq: remove extra fence request when locking PD Benjamin Cheng
2026-11-18 19:05 ` sashiko-bot
2026-11-19 13:35 ` Christian König [this message]
2026-11-18 18:52 ` [PATCH 6/8] drm/amdgpu/vm: stop using amdgpu_bo_fence Benjamin Cheng
2026-11-19 13:41 ` Christian König
2026-11-18 18:52 ` [PATCH 7/8] drm/amdgpu/uvd: " Benjamin Cheng
2026-11-19 13:43 ` Christian König
2026-11-18 18:52 ` [PATCH 8/8] drm/amdgpu/object: get rid of amdgpu_bo_fence Benjamin Cheng
2026-11-19 13:47 ` Christian König
2026-11-18 18:58 ` [PATCH 0/8] Consolidate and fix root PD fence resverations Benjamin Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45f84bc0-8d9c-44d8-b70b-e188f5fe210b@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=benjamin.cheng@amd.com \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=shahyan.soltani@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.