From: Paulo Marques <pmarques@grupopie.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Tasos Parisinos <t.parisinos@sciensis.com>,
herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1)
Date: Tue, 20 Mar 2007 15:43:52 +0000 [thread overview]
Message-ID: <46000138.20007@grupopie.com> (raw)
In-Reply-To: <20070319225858.GK10459@waste.org>
Matt Mackall wrote:
> [...]
>> + /* Allocate space for the mpi and its data */
>> + s = (size / 4) + ((size % 4)? 1: 0);
>
> Uhhh.. (size + 1) / 4?
You mean "(size + 3) / 4", no?
Overall, I agree with your comments: this file looks like it needs a lot
more CodingStyle ;)
Redefining standard kernel interfaces (error numbers, memory allocation,
printk, etc.) is not the right way to get code merged.
--
Paulo Marques - www.grupopie.com
"For every problem there is one solution which is simple, neat, and wrong."
H. L. Mencken
next prev parent reply other threads:[~2007-03-20 15:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 16:22 [PATCH RESEND 1/1] crypto API: RSA algorithm patch (kernel version 2.6.20.1) Tasos Parisinos
2007-03-19 22:58 ` Matt Mackall
2007-03-20 14:44 ` Tasos Parisinos
2007-03-20 15:15 ` Matt Mackall
2007-03-20 16:36 ` Jan Engelhardt
2007-03-20 15:43 ` Paulo Marques [this message]
2007-03-20 0:40 ` Francois Romieu
2007-03-20 14:11 ` Tasos Parisinos
2007-03-20 15:09 ` James Morris
2007-03-20 15:40 ` Tasos Parisinos
2007-03-20 21:43 ` Indan Zupancic
2007-03-21 9:15 ` Tasos Parisinos
2007-03-21 12:08 ` Indan Zupancic
2007-03-21 12:34 ` Tasos Parisinos
2007-03-21 13:00 ` Indan Zupancic
2007-03-21 23:31 ` David Schwartz
2007-03-22 13:15 ` Indan Zupancic
2007-03-21 12:36 ` Indan Zupancic
2007-03-21 13:07 ` Tasos Parisinos
2007-03-21 13:59 ` Indan Zupancic
2007-03-21 14:31 ` Tasos Parisinos
2007-03-21 15:10 ` Indan Zupancic
2007-03-21 15:50 ` Tasos Parisinos
2007-03-21 16:36 ` Indan Zupancic
2007-03-22 7:47 ` Tasos Parisinos
2007-03-21 14:49 ` Tasos Parisinos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46000138.20007@grupopie.com \
--to=pmarques@grupopie.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=t.parisinos@sciensis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.