From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: dsaxena@plexity.net, netdev@vger.kernel.org, ralf@linux-mips.org,
jeff@garzik.org, linux-mips@linux-mips.org, mlachwani@mvista.com
Subject: Re: [PATCH] Netpoll support for Sibyte MAC
Date: Tue, 20 Mar 2007 21:35:53 +0300 [thread overview]
Message-ID: <46002989.5000609@ru.mvista.com> (raw)
In-Reply-To: <20070320.102248.68134682.nemoto@toshiba-tops.co.jp>
Hello.
Atsushi Nemoto wrote:
>>NETPOLL support for Sibyte MAC
>>Signed-off-by: Manish Lachwani <mlachwani@mvista.com>
>>Signed-off-by: Deepak Saxena <dsaxena@mvista.com>
> If you added NETPOLL support, do not forget to ensure hard_start_xmit
> routine callable from interrupt context (or irq disabled).
> See commit bce305f4fe779f29d99d414685243f5da0803254 for example.
You're absolutely right: this driver is very likely to blow up the caller
when called with interrupts disabled -- it uses spin_unlock_irq() there! This
*must* be fixed.
> ---
> Atsushi Nemoto
WBR, Sergei
next prev parent reply other threads:[~2007-03-20 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 22:43 [PATCH] Netpoll support for Sibyte MAC Deepak Saxena
2007-03-20 1:22 ` Atsushi Nemoto
2007-03-20 18:35 ` Sergei Shtylyov [this message]
2007-03-20 13:38 ` Ralf Baechle
2007-03-20 14:34 ` Sergei Shtylyov
2007-03-23 5:58 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46002989.5000609@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=dsaxena@plexity.net \
--cc=jeff@garzik.org \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@mvista.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.