From: Thomas Meyer <thomas@m3y3r.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: Bug in pci_restore_msi_state
Date: Tue, 20 Mar 2007 22:07:59 +0100 [thread overview]
Message-ID: <46004D2F.4020901@m3y3r.de> (raw)
In-Reply-To: <84144f020703170618x73808b4fmf5b420f4c2e02818@mail.gmail.com>
Pekka Enberg schrieb:
> On 3/17/07, Thomas Meyer <thomas@m3y3r.de> wrote:
>> Hello everybody.
>>
>> I get this bug after suspending to disk twice:
>>
>> http://m3y3r.de/bilder/Bug-pci_restore_msi_state.png
>>
>> This happens with current git head
>> cd05a1f818073a623455a58e756c5b419fc98db9.
>
> If you know a kernel that works, please consider doing git bisect:
>
> http://www.kernel.org/pub/software/scm/git/docs/howto/isolate-bugs-with-bisect.txt
>
>
Ok. The error happens in the call of pcibios_enable_device in the
function do_pci_enable_device (drivers/pci/pci.c):
Before the call of pcibios_enable_device:
do_pci_enable_device: pci_dev= c1a40000
do_pci_enable_device: irq= 218
do_pci_enable_device: msi_enabled= 1
after the call:
ACPI: PCI Interrupt 0000:00:1f.2[B] -> GSI 19 (level, low) -> IRQ 19
do_pci_enable_device: pci_dev= c1a40000
do_pci_enable_device: irq= 19
do_pci_enable_device: msi_enabled= 1
So the function acpi_pci_irq_enable in drivers/acpi/pci_irq.c needs to
be fixed:
a.) acpi_pci_irq_enable should care about msi setups and set the flag
msi_enabled to 0 or
b.) acpi_pci_irq_enable should care about msi setups and should touch
the dev->irq field.
Please comment on this.
with kind regards
thomas
next prev parent reply other threads:[~2007-03-20 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-17 12:42 Bug in pci_restore_msi_state Thomas Meyer
2007-03-17 13:18 ` Pekka Enberg
2007-03-17 18:31 ` Thomas Meyer
2007-03-20 21:07 ` Thomas Meyer [this message]
2007-03-18 17:53 ` Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46004D2F.4020901@m3y3r.de \
--to=thomas@m3y3r.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.