From: Tejun Heo <htejun@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] ide: revert "ide: fix drive side 80c cable check, take 2" for now
Date: Wed, 21 Mar 2007 11:15:33 +0900 [thread overview]
Message-ID: <46009545.6060908@gmail.com> (raw)
In-Reply-To: <200703202154.13211.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> [PATCH] ide: revert "ide: fix drive side 80c cable check, take 2" for now
>
> "ide: fix drive side 80c cable check, take 2" patch from Tejun Heo (commit
> fab59375b9543f84d1714f7dd00f5d11e531bd3e) fixed 80c bit test (bit13 of word93)
> but we also need to fix master/slave IDENTIFY order (slave device should be
> probed first in order to make it release PDIAG- signal) and we should also
> check for pre-ATA3 slave devices (which may not release PDIAG- signal).
>
> [ Unfortunately the fact that IDE driver doesn't reset devices itself helps
> only a bit as it seems that some BIOS-es reset ATA devices after programming
> the chipset, some BIOS-es can be set to not probe/configure selected devices,
> there may be no BIOS in case of add-on cards etc. ]
>
> Since we are quite late in the release cycle and the required changes will
> affect a lot of systems just revert the fix for now.
>
> [ Please also see libata commit f31f0cc2f0b7527072d94d02da332d9bb8d7d94c. ]
>
> Thanks goes out to Fernando Mitio Yamada for reporting the problem
> and patiently testing patches.
>
> Cc: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Ackec-by: Tejun Heo <htejun@gmail.com>
Never suspected it could cause this much problem. :-(
--
tejun
prev parent reply other threads:[~2007-03-21 2:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 20:54 [PATCH] ide: revert "ide: fix drive side 80c cable check, take 2" for now Bartlomiej Zolnierkiewicz
2007-03-21 2:15 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46009545.6060908@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.