From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Wed, 21 Mar 2007 11:15:14 -0400 Subject: [U-Boot-Users] Update on the fdt command In-Reply-To: <20070321144944.E3C39352636@atlas.denx.de> References: <20070321144944.E3C39352636@atlas.denx.de> Message-ID: <46014C02.1050103@smiths-aerospace.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Hi, > > in message <46013C58.2040300@smiths-aerospace.com> you wrote: >> I'm getting close to having a functional "fdt" command. For a sneak >> peek you can look here: >> >> >> The new fdt command can be found here: >> >> (see line 777 ff. to see the subcommand list). Please critique my >> subcommands - it will hurt my feelings, but I'll get over it. > > Looks fine to me, but I cannot understand this part: > > 786 "fdt rm - Delete \n" > 787 "fdt rm - Delete the node *NOTE THE SPACE*\n" > > NOTE THE SPACE? Which one? And where is the difference? The space between and ... everywhere else, includes the last node and a space delimits the . I propose this to make parsing easier: I would not have to find the last "/" to find the node that was intended to be deleted. The alternative is: "fdt rm - Delete \n" "fdt rm - Delete the last node in \n" I have not implemented the rm command yet, so I'm flexible. It also means I have not tried it in real life... I wouldn't be surprised if I find the extra space between and is so annoying that it is worth finding the last '/' (which really isn't that difficult to parse). The advantage of specifying " " as I see it is that it is harder to screw up and delete major parts of the tree inadvertently rm /cpus # poof, all gone! when you really meant to do rm /cpus PowerPC,8560 at 0 Either way, I would not allow the deletion of the root node. For the -only version rm / is valid syntax but would be a problem - would have to test for this as a special case. For the , this becomes invalid syntax and would not be permitted. (Note that, either way, you can delete all the subnodes of the root '/' individually. Deleting the subnodes makes sense, deleting the root node itself does not.) >> My proposal to Wolfgang is that denx.de create a repository for my >> changes so I can submit them and ultimately he can pull the changes into >> the master repo. The changes to add David Gibson's libfdt to the source > > Is the name u-boot-fdt ok? Can you please send me your public SSH key? u-boot-fdt is great. I'll send you my key. > Best regards, > > Wolfgang Denk Thanks, gvb