From: Jeff Garzik <jeff@garzik.org>
To: Anton Blanchard <anton@samba.org>
Cc: netdev@vger.kernel.org
Subject: Re: Fix return code in pci-skeleton.c
Date: Fri, 23 Mar 2007 01:49:54 -0400 [thread overview]
Message-ID: <46036A82.1080600@garzik.org> (raw)
In-Reply-To: <20070316220021.GA11929@kryten>
Anton Blanchard wrote:
> We assign the return value of register_netdev to i, but return rc later
> on. Fix it.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
>
> diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
> index 00ca0fd..6ca4e4f 100644
> --- a/drivers/net/pci-skeleton.c
> +++ b/drivers/net/pci-skeleton.c
> @@ -710,8 +710,8 @@ match:
> tp->chipset,
> rtl_chip_info[tp->chipset].name);
>
> - i = register_netdev (dev);
> - if (i)
> + rc = register_netdev (dev);
> + if (rc)
> goto err_out_unmap;
applied
prev parent reply other threads:[~2007-03-23 5:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 22:00 Fix return code in pci-skeleton.c Anton Blanchard
2007-03-23 5:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46036A82.1080600@garzik.org \
--to=jeff@garzik.org \
--cc=anton@samba.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.