All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Li Yang <leoli@freescale.com>
Cc: netdev@vger.kernel.org, michael.barkowski@freescale.com
Subject: Re: [PATCH] Revert "ucc_geth: returns NETDEV_TX_BUSY when BD ring is full"
Date: Fri, 23 Mar 2007 01:50:11 -0400	[thread overview]
Message-ID: <46036A93.9070506@garzik.org> (raw)
In-Reply-To: <45FE0A4A.20402@freescale.com>

Li Yang wrote:
> This reverts commit 18babd38547a042a4bfd4154a014d1ad33373eb0.
> 
> Michael Barkowski points out that it's wrong, and I agree.  The
> patch causes a problem rather than fixes one after another
> patch "ucc_geth: Fix BD processing" was applied.  Before that
> patch, current packet should be blocked.  However after the patch
> current packet is ok and we only need to block next.
> 
> Reported-by: Michael Barkowski <michael.barkowski@freescale.com>
> Signed-off-by: Li Yang <leoli@freescale.com>
> ---
> Sorry for the mistake I made.
> 
> drivers/net/ucc_geth.c |    3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)

applied



      reply	other threads:[~2007-03-23  5:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-19  3:58 [PATCH] Revert "ucc_geth: returns NETDEV_TX_BUSY when BD ring is full" Li Yang
2007-03-23  5:50 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46036A93.9070506@garzik.org \
    --to=jeff@garzik.org \
    --cc=leoli@freescale.com \
    --cc=michael.barkowski@freescale.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.