All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carsten Emde <Carsten.Emde-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [ANNOUNCE] kvm-17 release
Date: Sat, 24 Mar 2007 04:29:16 +0100	[thread overview]
Message-ID: <46049B0C.40501@osadl.org> (raw)
In-Reply-To: <46048C34.4080300-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>

Carsten Emde wrote:
> I then reverted to kvm-16 and repeated all upgrade changes until the 
> problem occurred. The culprit was found to be
> [..]
> +#ifdef THIS_PREVENTS_FC6_FROM_BOOTING
>   		emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0);
> +#endif
> [..]
Actually, the above line can be preserved, if we move the previous line 
down by 1: Was it a simple race?

--- kvm_main-17.c	2007-03-24 02:09:00.000000000 +0100
+++ kvm_main.c	2007-03-24 04:10:59.000000000 +0100
@@ -1574,8 +1574,8 @@

  	if (kvm_run->mmio_completed) {
  		memcpy(vcpu->mmio_data, kvm_run->mmio.data, 8);
-		vcpu->mmio_read_completed = 1;
  		emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0);
+		vcpu->mmio_read_completed = 1;
  	}

  	vcpu->mmio_needed = 0;


--
Carsten Emde <C.Emde-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

  parent reply	other threads:[~2007-03-24  3:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-20 13:27 [ANNOUNCE] kvm-17 release Avi Kivity
     [not found] ` <45FFE14F.6020808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-03-22 19:32   ` Michael Riepe
     [not found]     ` <4602D9D5.7060806-0QoEqw4nQxo@public.gmane.org>
2007-03-23  9:33       ` Avi Kivity
     [not found]         ` <46039EEA.4070504-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-03-24  2:25           ` Carsten Emde
     [not found]             ` <46048C34.4080300-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
2007-03-24  3:29               ` Carsten Emde [this message]
     [not found]                 ` <46049B0C.40501-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
2007-03-24 12:29                   ` Michael Riepe
     [not found]                     ` <460519A6.1020005-0QoEqw4nQxo@public.gmane.org>
2007-03-24 13:25                       ` Carsten Emde
2007-03-25  8:53                       ` Avi Kivity
2007-03-25  8:47                   ` Avi Kivity
2007-03-24 11:58               ` Michael Riepe
     [not found]                 ` <46051251.1020401-0QoEqw4nQxo@public.gmane.org>
2007-03-24 13:06                   ` Carsten Emde
2007-03-25  8:49                   ` Avi Kivity
2007-03-25  8:46               ` Avi Kivity
2007-03-23  9:43       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46049B0C.40501@osadl.org \
    --to=carsten.emde-q945khdl0dbytjvyw6ydsg@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.