From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] [NET] fib_rules: goto rule action
Date: Mon, 26 Mar 2007 21:13:07 -0700 [thread overview]
Message-ID: <460899D3.60808@osdl.org> (raw)
In-Reply-To: <20070326.171916.104032809.davem@davemloft.net>
David Miller wrote:
> From: Thomas Graf <tgraf@suug.ch>
> Date: Tue, 27 Mar 2007 01:54:51 +0200
>
>
>> This patch adds a new rule action FR_ACT_GOTO which allows
>> to skip a set of rules by jumping to another rule. The rule
>> to jump to is specified via the FRA_GOTO attribute which
>> carries a rule preference.
>>
>> Referring to a rule which doesn't exists is explicitely allowed.
>> Such goto rules are marked with the flag FIB_RULE_UNRESOLVED
>> and will act like a rule with a non-matching selector. The rule
>> will become functional as soon as its target is present.
>>
>> The goto action enables performance optimizations by reducing
>> the average number of rules that have to be passed per lookup.
>>
>> Example:
>> 0: from all lookup local
>> 40: not from all to 192.168.23.128 goto 32766
>> 41: from all fwmark 0xa blackhole
>> 42: from all fwmark 0xff blackhole
>> 32766: from all lookup main
>>
>> Signed-off-by: Thomas Graf <tgraf@suug.ch>
>>
>
> This looks excellent, applied to net-2.6.22, thanks Thomas.
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Do we have to worry about self inflicted infinite loops?
Shouldn't there be some way to some basic validation?
next prev parent reply other threads:[~2007-03-27 4:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 23:54 [PATCH 0/3] [PATCHSET] fib_rules: goto/nop action, flag for detached rules Thomas Graf
2007-03-26 23:54 ` [PATCH 1/3] [NET] fib_rules: goto rule action Thomas Graf
2007-03-27 0:19 ` David Miller
2007-03-27 4:13 ` Stephen Hemminger [this message]
2007-03-27 6:08 ` David Miller
2007-03-26 23:54 ` [PATCH 2/3] [NET] fib_rules: Mark rules detached from the device Thomas Graf
2007-03-27 0:38 ` David Miller
2007-03-26 23:54 ` [PATCH 3/3] [NET] fib_rules: Add no-operation action Thomas Graf
2007-03-27 0:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460899D3.60808@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.