From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tnt@246tNt.com>
Received: from outmx007.isp.belgacom.be (outmx007.isp.belgacom.be
	[195.238.5.234])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id D63EFDDEEF
	for <linuxppc-dev@ozlabs.org>; Tue, 27 Mar 2007 17:11:44 +1000 (EST)
Received: from outmx007.isp.belgacom.be (localhost [127.0.0.1])
	by outmx007.isp.belgacom.be (8.12.11.20060308/8.12.11/Skynet-OUT-2.22)
	with ESMTP id l2R7BQBF024238
	for <linuxppc-dev@ozlabs.org>; Tue, 27 Mar 2007 09:11:26 +0200
	(envelope-from <tnt@246tNt.com>)
Message-ID: <4608C390.5080205@246tNt.com>
Date: Tue, 27 Mar 2007 09:11:12 +0200
From: Sylvain Munaut <tnt@246tNt.com>
MIME-Version: 1.0
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH 08/10] macintosh: Use the new of_device common uevent
	handler
References: <11713184081457-git-send-email-tnt@246tNt.com>	
	<11713184091057-git-send-email-tnt@246tNt.com>	
	<11713184101239-git-send-email-tnt@246tNt.com>	
	<11713184112187-git-send-email-tnt@246tNt.com>	
	<11713184132161-git-send-email-tnt@246tNt.com>	
	<11713184141191-git-send-email-tnt@246tNt.com>	
	<11713184152189-git-send-email-tnt@246tNt.com>	
	<11713184171985-git-send-email-tnt@246tNt.com>	
	<11713184182928-git-send-email-tnt@246tNt.com>
	<1174977009.14065.0.camel@localhost.localdomain>
In-Reply-To: <1174977009.14065.0.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Linux PPC Dev ML <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

Benjamin Herrenschmidt wrote:
> On Mon, 2007-02-12 at 23:13 +0100, Sylvain Munaut wrote:
>   
>> The generation of the uevent is now common to all bus using
>> of_device.
>>     
>
> I haven't managed to figure out why so far (a quick inspection of the
> code didn't show anything obvious) but with your patch, the snd-aoa
> driver fails to auto-load at boot... might be the modalias being broken,
> dunno.
>
>   

Hi Ben,

Thanks for testing. That issue looks weird.

I had a look at sound/aoa/soundbus/i2sbus/i2sbus-core.c , which is the
only part of aoa with of_device_id and I see that it uses the
MODULE_ALIAS directly :
MODULE_ALIAS("of:Ni2sTi2sC");
instead of using
MODULE_DEVICE_TABLE(of, i2sbus_match);
and letting modpost do the job. Because that module alias is not the one
that's gonna be generated by modpost.

But that doesn't explain why it worked before and not now ...


      Sylvain