From: Jeff Garzik <jeff@garzik.org>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: Gabriel Paubert <paubert@iram.es>,
Manish Lachwani <mlachwani@mvista.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field
Date: Wed, 28 Mar 2007 02:19:14 -0400 [thread overview]
Message-ID: <460A08E2.4080904@garzik.org> (raw)
In-Reply-To: <20070323190351.GB28209@xyzzy.farnsworth.org>
Dale Farnsworth wrote:
> From: Gabriel Paubert <paubert@iram.es>
>
> In this driver, the default ethernet address is first set by by calling
> eth_port_uc_addr_get() which reads the relevant registers of the
> corresponding port as initially set by firmware. However that function
> used the port_num field accessed through the private area of net_dev
> before it was set.
>
> The result was that one board I have ended up with the unicast address
> set to 00:00:00:00:00:00 (only port 1 is connected on this board). The
> problem appeared after commit 84dd619e4dc3b0b1c40dafd98c90fd950bce7bc5.
>
> This patch fixes the bug by setting mp->port_num prior to calling
> eth_port_uc_get_addr().
>
> Signed-off-by: Gabriel Paubert <paubert@iram.es>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
> ---
applied #1 to upstream-fixes
prev parent reply other threads:[~2007-03-28 6:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 12:30 [PATCH] Fix use of uninitialized field in mv643xx_eth Gabriel Paubert
2007-03-23 15:38 ` Dale Farnsworth
2007-03-23 19:03 ` [PATCH 1/2] mv643xx_eth: Fix use of uninitialized port_num field Dale Farnsworth
2007-03-23 19:07 ` [PATCH 2/2] mv643xx_eth: make eth_port_uc_addr_{get,set}() calls symmetric Dale Farnsworth
2007-03-29 12:35 ` Jeff Garzik
2007-03-28 6:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460A08E2.4080904@garzik.org \
--to=jeff@garzik.org \
--cc=dale@farnsworth.org \
--cc=mlachwani@mvista.com \
--cc=netdev@vger.kernel.org \
--cc=paubert@iram.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.