From: Ethan Solomita <solo@google.com>
To: Andreas Mohr <andi@rhlx01.fht-esslingen.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Maneesh Soni <maneesh@in.ibm.com>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [FIXED] Re: tty OOPS (Re: 2.6.21-rc5-mm2)
Date: Wed, 28 Mar 2007 14:08:16 -0700 [thread overview]
Message-ID: <460AD940.8080507@google.com> (raw)
In-Reply-To: <20070328201511.GA20889@rhlx01.hs-esslingen.de>
Andreas Mohr wrote:
> Hi,
>
> On Wed, Mar 28, 2007 at 10:56:32PM +0400, Alexey Dobriyan wrote:
>
>> The only suspicious new patch in -rc5-mm1 to me is
>> fix-sysfs-reclaim-crash.patch which removes "sd->s_dentry = NULL;". Note
>> that whole sysfs_drop_dentry() is NOP if ->s_dentry is NULL.
>>
>> Could you try to revert it?
>>
>> Alexey, who knows very little about sysfs internals
>>
>
> Apparently that's still too much knowledge ;)
>
> Or, in other words: 6 reboots already and not a single problem!
>
> So yes, the removal of the NULLing line in this patch most likely
> has caused this issue on my box.
> Now the question is whether something as simple as that is a fully
> correct fix or whether something should be done entirely differently.
> I'll let people more familiar with those parts decide about it...
>
Sorry -- I've only just been cc'd on this mail thread. Are we
claiming that this patch/fix has caused a new problem, or successfully
fixed an old problem?
Thanks!
-- Ethan
next prev parent reply other threads:[~2007-03-28 21:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 5:16 2.6.21-rc5-mm2 Andrew Morton
2007-03-27 10:04 ` 2.6.21-rc5-mm2 William Lee Irwin III
2007-03-28 17:02 ` 2.6.21-rc5-mm2 Andreas Mohr
2007-03-28 17:33 ` 2.6.21-rc5-mm2 Andreas Mohr
2007-03-28 17:45 ` 2.6.21-rc5-mm2 Andreas Mohr
2007-03-28 18:04 ` tty OOPS (Re: 2.6.21-rc5-mm2) Andreas Mohr
2007-03-28 18:38 ` Alexey Dobriyan
2007-03-28 18:56 ` Alexey Dobriyan
2007-03-28 20:07 ` Andrew Morton
2007-03-29 12:48 ` Maneesh Soni
2007-03-28 20:15 ` [FIXED] " Andreas Mohr
2007-03-28 21:08 ` Ethan Solomita [this message]
2007-03-28 21:27 ` Ethan Solomita
2007-03-28 17:42 ` 2.6.21-rc5-mm2 Christian
2007-03-28 17:55 ` 2.6.21-rc5-mm2 Pallipadi, Venkatesh
2007-03-28 18:36 ` 2.6.21-rc5-mm2 Badari Pulavarty
2007-03-28 20:20 ` 2.6.21-rc5-mm2 OOPS and spinlock lockup Zan Lynx
2007-03-28 20:50 ` Andrew Morton
2007-03-29 17:53 ` 2.6.21-rc5-mm2 Badari Pulavarty
2007-03-29 17:23 ` 2.6.21-rc5-mm2 Andrew Morton
2007-03-29 18:20 ` 2.6.21-rc5-mm2 - compile error on x86-64 Helge Hafting
2007-03-29 21:28 ` Andrew Morton
2007-03-29 22:10 ` Eric W. Biederman
2007-03-29 22:23 ` Andrew Morton
2007-03-30 5:10 ` Eric W. Biederman
2007-03-29 22:24 ` Randy Dunlap
2007-03-31 6:27 ` Helge Hafting
2007-03-31 6:53 ` Eric W. Biederman
2007-03-31 6:50 ` Helge Hafting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460AD940.8080507@google.com \
--to=solo@google.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.