All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: smitchel <smitchel@bnin.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: possible mistake in linux kernel header file -- kernel: 2.6.16.29 file: mod_devicetable.h
Date: Wed, 28 Mar 2007 17:09:49 -0600	[thread overview]
Message-ID: <460AF5BD.60603@shaw.ca> (raw)
In-Reply-To: <fa.oyzxCetQPxeJg2D2eekG0Gighs4@ifi.uio.no>

smitchel wrote:
> I am not sure where to post this, maybe you can direct me what to do, if 
> anything.
> 
> We have two computers running slackware for amd64 version 11.0.
> Tonight we compiled mplayer on each of the systems.
> 
> On the first, everything compiled fine--it has a core 2 duo cpu and is 
> running a stock kernel off the install DVD for slackware-amd64.
> it is kernel 2.6.16.29.
> 
> On the second it would not compile, and it has dual opteron 250 cpus and 
> is running a kernel that we compiled to add some things to
> for sound, etc.   This was from a kernel source that we downloaded a few 
> days ago.
> it is kernel 2.6.16.29--same as first machine.
> 
> The error is stopping in the file /usr/include/linux/mod_devicetable.h.
> 
> It appears that there are 4 extra lines that have been added to the  
> mod_devicetable.h that was part of the kernel source that we downloaded.
> They are in the first screenful of the file:
> 
> #ifdef __KERNEL__
> #include <linux/types.h>
> typedef unsigned long kernel_ulong_t;
> #endif
> 
> They are not in the same file in the kernel source from the slackware 
> amd-64 install DVD. (<linux/types.h> included somewhere else?)
> 
> Googling we found:
> __KERNEL__ is defined for programs that run in kernel mode instead of 
> user programs (whatever that means).
> 
> A few lines later in mod_devicetable.h it uses the type kernel_ulong_t 
> (in the same file--what if the ifdef path is not taken?)

These compile errors are from compiling mplayer? Something is not right 
here, it shouldn't be including that header file at all - and I'm not 
sure how anything in /usr/include could be ending up trying to do so.

__KERNEL__ is only supposed to be defined when building the kernel 
itself. Current kernels (not sure if 2.6.16 had this though) have a 
process which generates header files suitable for userspace from the 
kernel's header files and strips out everything inside #ifdef __KERNEL__.

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


       reply	other threads:[~2007-03-28 23:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.oyzxCetQPxeJg2D2eekG0Gighs4@ifi.uio.no>
2007-03-28 23:09 ` Robert Hancock [this message]
2007-03-28  3:28 possible mistake in linux kernel header file -- kernel: 2.6.16.29 file: mod_devicetable.h smitchel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460AF5BD.60603@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=smitchel@bnin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.