Re: [PATCH] SVM: enable LBRV virtualization if available

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Joerg Roedel wrote:
> From: Joerg Roedel <joerg.roedel-5C7GfCeVMHo@public.gmane.org>
>
> This patch enables the virtualization of the last branch record MSRs on
> SVM if this feature is available in hardware. It also introduces a small
> and simple check feature for specific SVM extensions.
>   

> +#define SVM_DEATURE_SVML (1 << 2)
>   

FEATURE? DENTURE?

> +
> +#define svm_has(feat) (svm_features & (feat))
> +
>   

I prefer a static inline instead of a function-like macro.

>  unsigned long iopm_base;
>  unsigned long msrpm_base;
>  
> @@ -68,6 +74,7 @@ struct svm_cpu_data {
>  };
>  
>  static DEFINE_PER_CPU(struct svm_cpu_data *, svm_data);
> +static uint32_t svm_features;
>   

u32 outside userspace headers.

Anyway I fixed these up and applied.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV