From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: [NET_SCHED]: cls_basic: fix memory leak in basic_destroy
Date: Fri, 30 Mar 2007 19:02:53 +0200 [thread overview]
Message-ID: <460D42BD.6020500@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 883 bytes --]
[NET_SCHED]: cls_basic: fix memory leak in basic_destroy
tp->root is not freed on destruction.
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit b3df7f810c71b213224c105283c01e57ba7ed46a
tree 7f49d1edbc955609e369317a5a76100c87082377
parent 167c6a396949ee921bf70cbe58529f8e4dd4398d
author Patrick McHardy <kaber@trash.net> Fri, 30 Mar 2007 15:46:00 +0200
committer Patrick McHardy <kaber@trash.net> Fri, 30 Mar 2007 15:46:00 +0200
net/sched/cls_basic.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index e76803c..c885412 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -110,6 +110,7 @@ static void basic_destroy(struct tcf_proto *tp)
list_del(&f->link);
basic_delete_filter(tp, f);
}
+ kfree(head);
}
static int basic_delete(struct tcf_proto *tp, unsigned long arg)
next reply other threads:[~2007-03-30 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 17:02 Patrick McHardy [this message]
2007-03-30 20:41 ` [NET_SCHED]: cls_basic: fix memory leak in basic_destroy David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460D42BD.6020500@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.