From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Andi Kleen" <andi@firstfloor.org>,
"Paweł Sikora" <pluto@agmk.net>,
"Linux Kernel list" <linux-kernel@vger.kernel.org>
Subject: Re: smart gcc inliner...
Date: Fri, 30 Mar 2007 12:39:36 -0700 [thread overview]
Message-ID: <460D6778.6000207@goop.org> (raw)
In-Reply-To: <20070330193216.GJ14134@stusta.de>
Adrian Bunk wrote:
> On Tue, Mar 27, 2007 at 07:55:38PM -0700, Jeremy Fitzhardinge wrote:
>
>> Andi Kleen wrote:
>>
>>> init functions should only ever be called from other init functions.
>>>
>>> So this should not happen. If it happens the annotations need to be fixed.
>>>
>> I've seen some versions of gcc inline weak functions too.
>>
>
> Please be more precise:
> - gcc version
> - example code
> - bug number in the gcc Bugzilla
>
Sorry, it was a while ago, and I didn't take the time to fully report
it. It was FC6 on x86_64, doing a 32-bit cross-build. I'll see if I
can repro it.
> This would also help understanding what you are talking about:
> - Did gcc inline a global function?
> - Or was a static function declared as weak (which might be an error
> by the programmer)?
> - ...
>
It was, specifically, smp_setup_processor_id getting inlined into
start_kernel.
J
next prev parent reply other threads:[~2007-03-30 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 15:07 smart gcc inliner Paweł Sikora
2007-03-27 16:55 ` Andi Kleen
2007-03-28 2:55 ` Jeremy Fitzhardinge
2007-03-30 19:32 ` Adrian Bunk
2007-03-30 19:39 ` Jeremy Fitzhardinge [this message]
2007-03-28 2:05 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460D6778.6000207@goop.org \
--to=jeremy@goop.org \
--cc=andi@firstfloor.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pluto@agmk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.