From: Zachary Amsden <zach@vmware.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VMI paravirt-ops bugfix for 2.6.21
Date: Sat, 31 Mar 2007 01:19:32 -0800 [thread overview]
Message-ID: <460E27A4.1040606@vmware.com> (raw)
In-Reply-To: <460E1796.2070607@goop.org>
Jeremy Fitzhardinge wrote:
>
> The comment only talks about disabling interrupts for lazy_mmu, but this
> seems to do it for lazy_cpu as well. Is that OK? What happens if
> someone wants to change interrupt states under lazy_cpu; I can't think
> of an inherent reason why that wouldn't be allowed (though I don't think
> it happens now).
>
Well, lazy cpu is used only for context switch. Changing interrupt
states won't happen there.
> This kind of logic is a bit clunky anyway; would it be better to simply
> have separate enable/disable functions? Or at least separate functions
> per mode?
>
I want to do a cleaner fix for 2.6.22; this is pretty clunky, agree.
But it is still better to have fewer paravirt-ops. Perhaps lazy_enter /
flush would be more semantically useful.
Zach
next prev parent reply other threads:[~2007-03-31 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-31 8:45 [PATCH] VMI paravirt-ops bugfix for 2.6.21 Zachary Amsden
2007-03-31 8:02 ` Andrew Morton
2007-03-31 8:11 ` Jeremy Fitzhardinge
2007-03-31 8:11 ` Jeremy Fitzhardinge
2007-03-31 9:19 ` Zachary Amsden [this message]
2007-03-31 14:35 ` Andi Kleen
2007-04-01 7:01 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460E27A4.1040606@vmware.com \
--to=zach@vmware.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.