All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: Linux OMAP ML <linux-omap-open-source@linux.omap.com>,
	Hiroshi.DOYU@nokia.com
Subject: MMU FWK changes break OMAP1 compilation
Date: Sun, 01 Apr 2007 11:31:11 +0200	[thread overview]
Message-ID: <460F7BDF.4060105@googlemail.com> (raw)


Recent MMU FWK changes [1] and [2] break at least OMAP1 
compilation.

Issues:

- omap1_mmu_interrupt() in arch/arm/mach-omap1/mmu.c uses 
various MMU_xxx macros, but in arch/arm/mach-omap1/mmu.h 
they are called OMAP_MMU_xxx.

- omap1_mmu_interrupt() uses MK32 macro, which is defined in 
./plat-omap/dsp/dsp.h, which isn't included.

- omap1_mmu_interrupt() still uses MMUFAULT_MASK, which is 
removed from arch/arm/plat-omap/dsp/mmu.h by [2]. So [1] 
introduces MMUFAULT_MASK to mach-omap1/mmu.c while [2] 
removes it from dsp/mmu.h.

- dsp_mmu_itack() in arch/arm/plat-omap/dsp/mmu.h still uses 
dsp_fault_adr which is removed in same file by [2].

- Some compiler warnings:

arch/arm/plat-omap/dsp/dsp_mem.c: In function 'dsp_mem_ioctl':
arch/arm/plat-omap/dsp/dsp_mem.c:348: warning: unused 
variable 'ret'
arch/arm/plat-omap/dsp/dsp_mem.c:347: warning: unused 
variable 'dspadr'
arch/arm/plat-omap/dsp/mmu.h:88: warning: 'dspadr' is used 
uninitialized in this function

Anybody with a fix for these?

Cheers

Dirk

[1] 
<http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=6b13d95d4979ca9df91420fb5ab18fbfee3f9386>

[2] 
<http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=commit;h=68a575f924dbe0326ee1e4178f854cfed7933492>

             reply	other threads:[~2007-04-01  9:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-01  9:31 Dirk Behme [this message]
2007-04-02  6:11 ` MMU FWK changes break OMAP1 compilation Hiroshi DOYU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460F7BDF.4060105@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.