From: mabbas <mabbas@linux.intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [patch 3/5] A-MSDU Rx aggregation support
Date: Mon, 02 Apr 2007 23:30:23 -0700 [thread overview]
Message-ID: <4611F47F.2060809@linux.intel.com> (raw)
In-Reply-To: <1175111599.5151.123.camel@johannes.berg>
>
>> static ieee80211_txrx_result
>> ieee80211_rx_h_data(struct ieee80211_txrx_data *rx)
>> {
>> @@ -4373,6 +4510,7 @@ static ieee80211_rx_handler ieee80211_rx
>> ieee80211_rx_h_remove_qos_control,
>> ieee80211_rx_h_802_1x_pae,
>> ieee80211_rx_h_drop_unencrypted,
>> + ieee80211_rx_h_data_agg,
>> ieee80211_rx_h_data,
>> ieee80211_rx_h_mgmt,
>> NULL
>> diff -Nupr wireless-dev/net/mac80211/wme.h
>> wireless-dev-new/net/mac80211/wme.h
>> --- wireless-dev/net/mac80211/wme.h 2007-03-22 11:40:17.000000000 -0700
>> +++ wireless-dev-new/net/mac80211/wme.h 2007-03-27 01:48:34.000000000
>> -0700
>> @@ -24,6 +24,8 @@
>>
>> #define QOS_CONTROL_TAG1D_MASK 0x07
>>
>> +#define QOS_CONTROL_A_MSDU_PRESENT 0x80
I am calling ieee80211_rx_h_data_agg after ieee80211_rx_h_remove_qos_control which
clears all QoS data which include QOS_CONTROL_A_MSDU_PRESENT bit. We can solve this by
adding new field is_frame_agg to ieee80211_txrx_data.u.rx.is_frame_agg which will be set in
ieee80211_rx_h_parse_qos or we can add new function to ieee80211_rx_pre_handlers just to do that. the other
option is to shuffle calling sequence here if that possible to call ieee80211_rx_h_data_agg
before ieee80211_rx_h_remove_qos_control. any opinion?
Mohamed
next prev parent reply other threads:[~2007-04-02 18:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 11:40 [patch 3/5] A-MSDU Rx aggregation support mohamed
2007-03-26 23:36 ` Randy Dunlap
2007-03-29 6:16 ` mohamed
2007-03-28 18:19 ` Randy Dunlap
2007-03-28 18:23 ` Johannes Berg
2007-03-28 21:08 ` Michael Buesch
2007-03-29 11:06 ` Johannes Berg
2007-03-28 19:53 ` Johannes Berg
[not found] ` <1ba2fa240703291412g6bf0b38fv86c64c9171601b5e@mail.gmail.com>
2007-03-30 10:40 ` Johannes Berg
2007-04-03 6:30 ` mabbas [this message]
2007-04-02 18:38 ` Johannes Berg
2007-04-03 0:07 ` Tomas Winkler
2007-04-04 10:37 ` mabbas
2007-06-20 21:13 ` Johannes Berg
2007-07-18 0:01 ` John W. Linville
2007-07-18 10:29 ` Johannes Berg
2007-07-18 13:22 ` Tomas Winkler
2007-07-18 15:38 ` Johannes Berg
2007-07-18 15:51 ` Tomas Winkler
2007-07-18 16:56 ` Johannes Berg
2007-07-19 18:27 ` Tomas Winkler
2007-07-25 8:06 ` Tomas Winkler
2007-07-25 8:37 ` Johannes Berg
2007-07-25 18:05 ` mohamed salim abbas
2007-07-25 19:14 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4611F47F.2060809@linux.intel.com \
--to=mabbas@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.