All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH libata#upstream] sata_promise: decode and report error reasons
Date: Wed, 04 Apr 2007 01:43:49 -0400	[thread overview]
Message-ID: <46133B15.9020301@garzik.org> (raw)
In-Reply-To: <200703140851.l2E8pZ8A006182@harpo.it.uu.se>

Mikael Pettersson wrote:
> This patch adds much needed error reason decoding and
> reporting to sata_promise. It's simplistic but should
> log all relevant error info the controller provides.
> 
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
>  drivers/ata/sata_promise.c |   64 ++++++++++++++++++++++++++++++++++++++-------
>  1 files changed, 55 insertions(+), 9 deletions(-)
> 
> Changes since the preliminary version:
> * dropped SError decoding, as all bits there are standard
> * PDC2_HTO_ERR is mapped to AC_ERR_HOST_BUS not AC_ERR_TIMEOUT
> * PDC_UNDERRUN_ERR and PDC_OVERRUN_ERR are mapped to AC_ERR_HSM
>   not AC_ERR_ATA_BUS
> * added brief explanations to error constant declarations
> * some cleanups and simplifications

applied



  parent reply	other threads:[~2007-04-04  5:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-14  8:51 [PATCH libata#upstream] sata_promise: decode and report error reasons Mikael Pettersson
2007-03-14  9:06 ` Jeff Garzik
2007-04-04  5:43 ` Jeff Garzik [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-03-14  9:30 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46133B15.9020301@garzik.org \
    --to=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.