From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: hardreset on SERR_INTERNAL
Date: Wed, 04 Apr 2007 01:43:58 -0400 [thread overview]
Message-ID: <46133B1E.1030907@garzik.org> (raw)
In-Reply-To: <20070313162051.GH32687@htj.dyndns.org>
Tejun Heo wrote:
> There was a rare report where SB600 reported SERR_INTERNAL and SRST
> couldn't get it out of the failure mode. Hardreset on SERR_INTERNAL.
> As the problem is intermittent, whether this fixes the problem or not
> hasn't been verified yet, but hardresetting the channel on internal
> error is a good idea anyway.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7349c3d..fc11bb3 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1055,7 +1055,7 @@ static void ata_eh_analyze_serror(struct ata_port *ap)
> }
> if (serror & SERR_INTERNAL) {
> err_mask |= AC_ERR_SYSTEM;
> - action |= ATA_EH_SOFTRESET;
> + action |= ATA_EH_HARDRESET;
applied to #upstream
prev parent reply other threads:[~2007-04-04 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-13 16:20 [PATCH] libata: hardreset on SERR_INTERNAL Tejun Heo
2007-03-14 9:30 ` Jeff Garzik
2007-03-14 11:50 ` Tejun Heo
2007-04-04 5:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46133B1E.1030907@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.