All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Kyle Zeng <zengyhkyle@gmail.com>, pabeni@redhat.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, ssuryaextr@gmail.com
Subject: Re: [PATCH net] fix null-deref in ipv4_link_failure
Date: Sun, 10 Sep 2023 22:36:01 -0600	[thread overview]
Message-ID: <46139141-90f5-820e-2124-0c9fa80e755d@kernel.org> (raw)
In-Reply-To: <ZPqSfGGAwa1I69Sm@westworld>

On 9/7/23 9:18 PM, Kyle Zeng wrote:
> Currently, we assume the skb is associated with a device before calling
> __ip_options_compile, which is not always the case if it is re-routed by
> ipvs.
> When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
> This patch adds a check for the edge case and switch to use the net_device
> from the rtable when skb->dev is NULL.
> 
> Suggested-by: Paolo Abeni<pabeni@redhat.com>
> Suggested-by: David Ahern <dsahern@kernel.org>
> Signed-off-by: Kyle Zeng <zengyhkyle@gmail.com>
> Cc: Stephen Suryaputra <ssuryaextr@gmail.com>
> ---
>  net/ipv4/route.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>



  parent reply	other threads:[~2023-09-11  4:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08  3:18 [PATCH net] fix null-deref in ipv4_link_failure Kyle Zeng
2023-09-08 20:13 ` Vadim Fedorenko
2023-09-11  4:36 ` David Ahern [this message]
2023-09-11  6:09 ` Paolo Abeni
  -- strict thread matches above, loose matches on Subject: below --
2023-09-12  2:35 Kyle Zeng
2023-09-12 15:58 ` David Ahern
2023-09-14  9:17 ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46139141-90f5-820e-2124-0c9fa80e755d@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ssuryaextr@gmail.com \
    --cc=zengyhkyle@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.