From: Timur Tabi <timur@freescale.com>
To: Sylvain Munaut <tnt@246tNt.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: change rheap functions to use long integers instead of pointers
Date: Wed, 04 Apr 2007 13:13:26 -0500 [thread overview]
Message-ID: <4613EAC6.5000203@freescale.com> (raw)
In-Reply-To: <4613E7CC.1020001@246tNt.com>
Sylvain Munaut wrote:
> But you're right, your not changing the actual values returned,
> ERR_PTR(x) == x ....
> So if someone wants to use it with addresses, he still can. He should
> just do cast to (void *). And to detect errors on alloc he should he
> IS_ERR(...)
How about I change rh_alloc() to return unsigned long, instead of just long, and then the
callers can use IS_ERR_VALUE() to check for error?
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-04-04 18:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 16:02 [PATCH] powerpc: change rheap functions to use long integers instead of pointers Timur Tabi
2007-04-04 16:42 ` Kumar Gala
2007-04-04 17:36 ` Pantelis Antoniou
2007-04-04 17:42 ` Timur Tabi
2007-04-04 18:00 ` Sylvain Munaut
2007-04-04 18:05 ` Timur Tabi
2007-04-04 18:13 ` Timur Tabi [this message]
2007-04-04 19:15 ` Dan Malek
2007-04-04 19:20 ` Timur Tabi
2007-04-04 19:31 ` Sylvain Munaut
2007-04-04 18:13 ` Scott Wood
2007-04-04 18:19 ` Timur Tabi
2007-04-04 18:24 ` Scott Wood
2007-04-04 18:27 ` Timur Tabi
2007-04-04 18:31 ` Scott Wood
2007-04-04 18:34 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4613EAC6.5000203@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.