Re: [PATCH] HPA support: Revised patch

[Jeff Garzik <jeff@garzik.org>]

Alan Cox wrote:
>>> +static int ata_ignore_hpa = 0;
>>> +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
>>> +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)");
>>> +
>>>  static int ata_probe_timeout = ATA_TMOUT_INTERNAL / HZ;
>>>  module_param(ata_probe_timeout, int, 0444);
>>>  MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout (seconds)");
>> For ignore_hpa, it would be nice to not go through inverse logic and
>> fix the help text a bit (0=honor HPA, 1=ignore HPA).
> 
> Umm.. how about  "preserve_hpa" ?

I think he meant fix the help text?

Regardless, it should be "ignore_hpa" as you have it now, though I feel 
the help text requires additional human brain parsing, and could be more 
clear.

	Jeff