From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: Benjamin LaHaise <bcrl@kvack.org>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: What protects cpu_tlbstate?
Date: Thu, 05 Apr 2007 14:08:24 -0700 [thread overview]
Message-ID: <46156548.6080102@goop.org> (raw)
In-Reply-To: <200704052303.35846.ak@suse.de>
Andi Kleen wrote:
>> Hm, I was more wondering about simple compiler reordering. Does the
>> relative order of setting and reading cpu_tlbstate.state, active_mm and
>> the mm->cpu_vm_mask matter?
>>
>
> Hmm, perhaps a barrier between state and active_mm might be a good idea.
> Setting active_mm after state might be problematic.
> cpu_vm_mask should be already a memory barrier.
>
Should leave_mm update active_mm and set the state to TLBSTATE_OK? Just
reloading cr3 seems a bit blunt.
J
prev parent reply other threads:[~2007-04-05 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 19:44 What protects cpu_tlbstate? Jeremy Fitzhardinge
2007-04-05 20:28 ` Andi Kleen
2007-04-05 21:00 ` Jeremy Fitzhardinge
2007-04-05 21:03 ` Andi Kleen
2007-04-05 21:08 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46156548.6080102@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=bcrl@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.