From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mark Langsdorf" Subject: Re: [PATCH][retry 2] Report the number of processors in PowerNow-k8 correctly Date: Thu, 05 Apr 2007 16:21:02 -0500 Message-ID: <4615683E.7030306@amd.com> References: <46096F1F.8030201@amd.com> <20070405202958.GA28783@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070405202958.GA28783@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cpufreq-bounces@lists.linux.org.uk Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org+glkc-cpufreq=gmane.org@lists.linux.org.uk Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Dave Jones Cc: cpufreq@lists.linux.org.uk I hope you had a good vacation. > Applying '[CPUFREQ] Report the number of processors in PowerNow-k8 correctly' > > error: patch failed: arch/i386/kernel/cpu/cpufreq/powernow-k8.c:661 > error: arch/i386/kernel/cpu/cpufreq/powernow-k8.c: patch does not apply Weird. I'm not doing anything complicated. Consolidated patch below. The PowerNow! driver for Opteron reports the number of cores in the system, but claims to report the number of processors. Fix this minor cosmetic bug. Signed-Off-By: Bhavana Nagendra Acked-by: Mark Langsdorf --- linux-2.6.20/arch/i386/kernel/cpu/cpufreq/powernow-k8.c.old 2007-04-05 15:43:36.000000000 -0500 +++ linux-2.6.20/arch/i386/kernel/cpu/cpufreq/powernow-k8.c 2007-04-05 15:45:03.000000000 -0500 @@ -661,7 +661,8 @@ static int fill_powernow_table(struct po dprintk("cfid 0x%x, cvid 0x%x\n", data->currfid, data->currvid); data->powernow_table = powernow_table; - print_basics(data); + if (first_cpu(cpu_core_map[data->cpu]) == data->cpu) + print_basics(data); for (j = 0; j < data->numps; j++) if ((pst[j].fid==data->currfid) && (pst[j].vid==data->currvid)) @@ -814,7 +815,8 @@ static int powernow_k8_cpu_init_acpi(str /* fill in data */ data->numps = data->acpi_data.state_count; - print_basics(data); + if (first_cpu(cpu_core_map[data->cpu]) == data->cpu) + print_basics(data); powernow_k8_acpi_pst_values(data, 0); /* notify BIOS that we exist */