From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Suleiman Souhlal <ssouhlal@freebsd.org>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled
Date: Fri, 06 Apr 2007 23:22:02 +0400 [thread overview]
Message-ID: <46169DDA.6020008@ru.mvista.com> (raw)
In-Reply-To: <20070406173603.GA82722@freefall.freebsd.org>
Hello.
Suleiman Souhlal wrote:
> It is possible for the timer expiry function to run even though the
> request has already been handled: ide_timer_expiry() only checks that
> the handler is not NULL, but it is possible that we have handled a
> request (thus clearing the handler) and then started a new request
> (thus starting the timer again, and setting a handler).
> A simple way to exhibit this is to set the DMA timeout to 1 jiffy and
> run dd: The kernel will panic after a few minutes because
> ide_timer_expiry() tries to add a timer when it's already active.
> To fix this, we simply add a request generation count that gets
> incremented at every interrupt, and check in ide_timer_expiry() that
> we have not already handled a new interrupt before running the expiry
> function.
Couldn't this be addressed by simply changing add_timer() to mod_timer()?
MBR, Sergei
next prev parent reply other threads:[~2007-04-06 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 17:36 [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled Suleiman Souhlal
2007-04-06 19:22 ` Sergei Shtylyov [this message]
2007-04-06 20:55 ` Suleiman Souhlal
2007-04-06 20:55 ` Suleiman Souhlal
2007-04-06 21:09 ` Sergei Shtylyov
2007-04-06 21:19 ` Interrupt posted but not delivered Kirill Yushkov
2007-04-06 21:35 ` [PATCH] Correctly prevent IDE timer expiry function to run if request was already handled Bartlomiej Zolnierkiewicz
2007-04-06 20:51 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46169DDA.6020008@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssouhlal@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.