From: Nishanth Menon <menon.nishanth@gmail.com>
To: "Syed Mohammed, Khasim" <x0khasim@ti.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [RFC-PATCH] Move i2c adaptor speed from a module parameter toplatform device resource
Date: Sat, 07 Apr 2007 10:34:20 -0500 [thread overview]
Message-ID: <4617B9FC.8060102@gmail.com> (raw)
In-Reply-To: <9C23CDD79DA20A479D4615857B2E2C47A19D34@dlee13.ent.ti.com>
Syed Mohammed, Khasim stated on 4/6/2007 5:00 PM:
>> This, however, requires the following follow up patches:
>> * Move i2c platform from plat-omap to respective board files.
>> * Reasoning: I2C speed at 100Khz is not always optimal for I2C1 by
>> * default (e.g. 3430).
>> * Impact: all board files will need to have it...but it will ensure
>> * that the i2c init is done in the proper sequence - 1 followed by
>>
> 2.
>
> We had discussed this before, but Tony was not "for" this approach.
> http://linux.omap.com/pipermail/linux-omap-open-source/2006-November/008
>
>
The argument then was that we could have a common definition for all
platform. if we look at our code, if have enough amount of #ifdefs that
we have been trying to avoid..
at the very least, it should move out to mach-omapx/devices.c
Regards,
Nishanth Menon
prev parent reply other threads:[~2007-04-07 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-03 0:14 [RFC-PATCH] Move i2c adaptor speed from a module parameter to platform device resource nishanth menon
2007-04-06 22:00 ` [RFC-PATCH] Move i2c adaptor speed from a module parameter toplatform " Syed Mohammed, Khasim
2007-04-07 15:34 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4617B9FC.8060102@gmail.com \
--to=menon.nishanth@gmail.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=x0khasim@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.