All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata#upstream] sata_promise: fix error decode regression
Date: Mon, 09 Apr 2007 16:52:53 +0900	[thread overview]
Message-ID: <4619F0D5.1020908@gmail.com> (raw)
In-Reply-To: <200704071229.l37CTp6M010861@harpo.it.uu.se>

Mikael Pettersson wrote:
> Promise ATA ports should always be reset by pdc_reset_port()
> when errors are detected, but the recent error reason decoding
> update to sata_promise replaced that reset with a freeze.
> 
> This patch changes the error detection to do a reset again.
> This makes the error decoding update safer, as it now only
> adds error decoding without changing any other behaviour.
> 
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>

Not necessarily NAK'ing but I think it's better to do things like that
in EH thread not in the interrupt handler.  Isn't freezing enough in the
interrupt handler?

Thanks.

-- 
tejun

  reply	other threads:[~2007-04-09  7:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-07 12:29 [PATCH libata#upstream] sata_promise: fix error decode regression Mikael Pettersson
2007-04-09  7:52 ` Tejun Heo [this message]
2007-04-17 14:29 ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2007-04-09  8:54 Mikael Pettersson
2007-04-09  9:16 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4619F0D5.1020908@gmail.com \
    --to=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.