From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement and use DMA mask configuration helper
Date: Mon, 09 Apr 2007 04:47:35 -0400 [thread overview]
Message-ID: <4619FDA7.10007@garzik.org> (raw)
In-Reply-To: <4619ECB7.9060601@gmail.com>
Tejun Heo wrote:
> Jeff, there are further problems with doing pci_go_64() only on devices
> which support 64bit. pci_set_dma_mask() is the only place where the PCI
> code can test whether DMA is usable or not, so if we don't configure DMA
> mask on 32bit controllers, there's no way to tell whether DMA is allowed
> on the controller/bus or not. We end up blindly enabling bus mastering
> without consulting the PCI bus.
>
> I think it's just cleaner to do pci_configure_dma_masks() on all cases
> with proper DMA mask.
There is always a cleaner solution :)
My implementation is based on current practice for all 64-bit drivers.
If you wish to change current practice, that is another matter...
Jeff
next prev parent reply other threads:[~2007-04-09 8:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 10:49 [PATCH] libata: implement and use DMA mask configuration helper Tejun Heo
2007-03-09 12:41 ` Jeff Garzik
2007-03-09 13:03 ` Tejun Heo
2007-03-18 14:48 ` Tejun Heo
2007-03-18 17:47 ` Jeff Garzik
2007-03-18 17:54 ` Tejun Heo
2007-04-09 7:35 ` Tejun Heo
2007-04-09 8:47 ` Jeff Garzik [this message]
2007-04-09 9:20 ` Tejun Heo
2007-03-09 12:51 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4619FDA7.10007@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.