From: Timur Tabi <timur@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, tnt@246tNt.com
Subject: Re: [PATCH v2] powerpc: change rheap functions to use ulongs instead of pointers
Date: Tue, 10 Apr 2007 13:46:01 -0500 [thread overview]
Message-ID: <461BDB69.4050405@freescale.com> (raw)
In-Reply-To: <DEB47A44-7FBF-40AD-B409-12A9BFA35976@kernel.crashing.org>
Kumar Gala wrote:
> If we are "cleaning up" rheap I would suggest we think about moving
> it to the generic lib directory and have it available for wider use
> beyond powerpc.
I'm not saying that's a bad idea, but that really is outside the scope of my intentions.
I'm not really cleaning up rheap as I am fixing one specific problem.
I don't think there's any disagreement here that an integer type (in this case, unsigned
long) is better than a void * for storing a generic value. I was really hoping I could
get a consensus on whether or not *this* patch is good for *our* rheap implementation.
--
Timur Tabi
Linux Kernel Developer @ Freescale
next prev parent reply other threads:[~2007-04-10 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 22:07 [PATCH v2] powerpc: change rheap functions to use ulongs instead of pointers Timur Tabi
2007-04-09 21:25 ` Timur Tabi
2007-04-10 18:31 ` Kumar Gala
2007-04-10 18:46 ` Timur Tabi [this message]
2007-04-10 19:04 ` Kumar Gala
2007-04-10 19:09 ` Timur Tabi
2007-04-10 19:32 ` Kumar Gala
2007-04-10 19:42 ` Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461BDB69.4050405@freescale.com \
--to=timur@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.