From: "H. Peter Anvin" <hpa@zytor.com>
To: Egmont Koblinger <egmont@uhulinux.hu>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] console UTF-8 fixes
Date: Wed, 11 Apr 2007 11:36:40 -0700 [thread overview]
Message-ID: <461D2AB8.5080902@zytor.com> (raw)
In-Reply-To: <20070411182801.GC26382@uhulinux.hu>
Egmont Koblinger wrote:
> +static int is_zero_width(long ucs)
> +{
> + static const struct interval zero_width[] = {
/* lots */
> + };
I'm still unhappy about these large search tables in the kernel, not
because they take a huge amount of space (it's not that much), but
because they're invariably going to be stale, as they're Unicode-version
dependent.
At least please put them in a separate .c file and include a script to
generate them clean from UnicodeData.txt.
Besides, would it not make more sense to have a single table with the
width information, if you insist on having one, instead of multiple ones?
-hpa
next prev parent reply other threads:[~2007-04-11 18:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 19:12 [PATCH] console UTF-8 fixes Egmont Koblinger
2007-04-06 19:43 ` H. Peter Anvin
2007-04-07 9:24 ` Egmont Koblinger
2007-04-07 11:00 ` Jan Engelhardt
2007-04-07 17:26 ` Egmont Koblinger
2007-04-07 17:59 ` H. Peter Anvin
2007-04-10 9:43 ` Egmont Koblinger
2007-04-10 15:43 ` H. Peter Anvin
2007-04-10 17:19 ` Egmont Koblinger
2007-04-10 17:30 ` H. Peter Anvin
2007-04-10 18:51 ` Egmont Koblinger
2007-04-11 12:58 ` Jan Engelhardt
2007-04-10 17:36 ` Alan Cox
2007-04-10 17:36 ` H. Peter Anvin
2007-04-11 18:28 ` Egmont Koblinger
2007-04-11 18:36 ` H. Peter Anvin [this message]
2007-04-12 9:11 ` Egmont Koblinger
2007-04-12 15:36 ` H. Peter Anvin
2007-04-12 16:41 ` Jan Engelhardt
2007-04-12 16:55 ` Egmont Koblinger
2007-04-12 16:58 ` H. Peter Anvin
2007-04-12 17:16 ` Egmont Koblinger
2007-04-12 17:35 ` H. Peter Anvin
2007-04-12 17:44 ` Egmont Koblinger
2007-04-12 17:49 ` H. Peter Anvin
2007-04-12 18:46 ` Jan Engelhardt
2007-04-12 12:54 ` Egmont Koblinger
2007-04-12 13:13 ` Alan Cox
2007-04-12 14:06 ` Egmont Koblinger
2007-04-12 14:38 ` Roman Zippel
2007-04-12 14:58 ` Egmont Koblinger
2007-04-12 15:52 ` Roman Zippel
2007-04-12 16:36 ` Egmont Koblinger
2007-04-12 18:09 ` Roman Zippel
2007-04-11 19:00 ` Jan Engelhardt
2007-04-12 9:22 ` Egmont Koblinger
2007-04-11 19:36 ` Pavel Machek
2007-04-12 8:14 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2007-04-17 10:22 Egmont Koblinger
2007-06-19 12:13 ` Egmont Koblinger
[not found] <8aT6Q-3iM-17@gated-at.bofh.it>
[not found] ` <8xLa7-25v-5@gated-at.bofh.it>
2007-06-19 13:54 ` Bodo Eggert
2007-06-19 14:42 ` Egmont Koblinger
2007-06-19 17:10 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461D2AB8.5080902@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=egmont@uhulinux.hu \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.