From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Chris Wright <chrisw@sous-sol.org>,
Hugh Dickins <hugh@veritas.com>,
David Rientjes <rientjes@google.com>,
Michel Lespinasse <walken@vmware.com>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] Pte drop ptep_get_and_clear paravirt op.patch
Date: Thu, 12 Apr 2007 12:48:38 -0700 [thread overview]
Message-ID: <461E8D16.6060202@goop.org> (raw)
In-Reply-To: <200704120530.l3C5Ubs0022821@zach-dev.vmware.com>
Zachary Amsden wrote:
> In shadow mode hypervisors, ptep_get_and_clear achieves the desired
> purpose of keeping the shadows in sync by issuing a native_get_and_clear,
> followed by a call to pte_update, which indicates the PTE has been
> modified.
>
> Direct mode hypervisors (Xen) have no need for this anyway, and will trap
> the update using writable pagetables.
>
> This means no hypervisor makes use of ptep_get_and_clear; there is no
> reason to have it in the paravirt-ops structure. Change confusing
> terminology about raw vs. native functions into consistent use of
> native_pte_xxx for operations which do not invoke paravirt-ops.
>
Looks OK to me. Are you going to put this into the pvops queue?
Acked-by: Jeremy Fitzhardinge <jeremy@xensource.com>
J
next prev parent reply other threads:[~2007-04-12 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 5:30 [PATCH 1/4] Pte drop ptep_get_and_clear paravirt op.patch Zachary Amsden
2007-04-12 19:48 ` Jeremy Fitzhardinge [this message]
2007-04-12 19:47 ` Zachary Amsden
2007-04-17 13:32 ` Jeremy Fitzhardinge
2007-04-17 11:18 ` Zachary Amsden
2007-04-18 13:05 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=461E8D16.6060202@goop.org \
--to=jeremy@goop.org \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
--cc=walken@vmware.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.