Re: [Fwd: policycoreutils patches]

[Daniel J Walsh <dwalsh@redhat.com>]

Stephen Smalley wrote:
> On Fri, 2007-04-13 at 08:53 -0400, Daniel J Walsh wrote:
>   
>> Moved audit2allow to sbin to match audit2why.
>>     
>
> (one patch per message would be nicer)
>
> I actually don't like having so many of the programs in /sbin
> or /usr/sbin, as they aren't in normal user paths and make it more
> painful to find the commands.  And moving them can cause user confusion
> and/or script breakage.  
>
>   
Then for consistency we should move audit2why to the same directory as 
audit2allow.
>> Fix chcat to handle case where there are no categories.
>>
>> Change fixfiles to run setfiles in quiet mode
>>
>> Change genhomedircon to verify context before setting homedir file
>> context. This can happen if you have different user types, where one
>> type has a homedir file context while another one does not.
>>     
>
> Not sure I understand - what does it mean to not have a homedir file
> context for a given user type?   I can understand that multiple user
> roles/types might share the same homedir file context, but not lacking
> one altogether.
>   
Example.  I am about to release a policy creating a guest_t.  This user 
will have very little privs on a system.  The goal of this user type is 
that it will only be used for ssh accounts.  So it will not have a 
guest_mozilla_home_t.  Since it can not even use X-Windows.   Currently 
if I had mozilla policy installed genhomedircon will try to generate 
file context with guest_mozilla_home_t.
>   
>> restorecond init script does not return status properly
>>
>> Fix output of restorecon.c errors to show correct error message.
>>     
>
> Adding a ": %s" with strerror(errno) is fine, but I don't think you want
> to drop the existing error message altogether, as errno isn't always set
> properly. 
>
>   

That error message is misleading and happens on messages that have 
nothing to do " error while labeling files under".



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.