All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kyle McMartin <kyle@canonical.com>,
	Robert Hancock <hancockr@shaw.ca>,
	linux-ide@vger.kernel.org, jgarzik@pobox.com,
	bcollins@ubuntu.com
Subject: Re: [PATCH] sata_nv: Don't attempt using ADMA for (READ|SET)_MAX commands
Date: Fri, 13 Apr 2007 14:14:42 -0400	[thread overview]
Message-ID: <461FC892.6020602@rtr.ca> (raw)
In-Reply-To: <20070413181935.6d60f230@the-village.bc.nu>

Alan Cox wrote:
> On Fri, 13 Apr 2007 13:08:31 -0400
> Kyle McMartin <kyle@canonical.com> wrote:
> 
>> READ_NATIVE_MAX and SET_MAX were causing timeouts on sata_nv controllers.
>> Disabling ADMA helped, but that is quite a large hammer to use. Reverting
>> 382a6652e91b34d5480cfc0ed840c196650493d4 also helped, but we might as well
>> fix it right, instead of disabling the performance gain on cache flushes
>> by using ADMA mode.
> 
> Probably not going to make any performance difference to blacklist all
> non-data commands or all but a few like cache-flush. 

I agree.  The Pacific Digital ADMA stuff had some quirks for various non-data
commands as well, and the sensible thing was to just not use ADMA for anything
other than READs/WRITEs and possible CACHE FLUSHes.

Cheers

  reply	other threads:[~2007-04-13 18:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-13 17:08 [PATCH] sata_nv: Don't attempt using ADMA for (READ|SET)_MAX commands Kyle McMartin
2007-04-13 17:19 ` Alan Cox
2007-04-13 18:14   ` Mark Lord [this message]
2007-04-13 22:52     ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=461FC892.6020602@rtr.ca \
    --to=liml@rtr.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bcollins@ubuntu.com \
    --cc=hancockr@shaw.ca \
    --cc=jgarzik@pobox.com \
    --cc=kyle@canonical.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.