From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Date: Thu, 27 Jul 2017 08:36:15 +0200 Message-ID: <4621265.xPXIvBV6Fl@diego> References: <1500973788-14627-1-git-send-email-rocky.hao@rock-chips.com> <1500973788-14627-2-git-send-email-rocky.hao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1500973788-14627-2-git-send-email-rocky.hao-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rocky Hao Cc: rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org, cl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org, jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org, huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-pm@vger.kernel.org Hi Rocky, Am Dienstag, 25. Juli 2017, 17:09:44 CEST schrieb Rocky Hao: > attempt to new compatible for thermal founding on RK3328 SoC. > > Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c > Signed-off-by: Rocky Hao generally looks good but you should not have gerrit Change-Ids in patches for mainline. This is true for all patches in this series. Heiko > --- > Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index > 43003aec94bd..e3a6234fb1ac 100644 > --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible : should be "rockchip,-tsadc" > "rockchip,rk3228-tsadc": found on RK3228 SoCs > "rockchip,rk3288-tsadc": found on RK3288 SoCs > + "rockchip,rk3328-tsadc": found on RK3328 SoCs > "rockchip,rk3368-tsadc": found on RK3368 SoCs > "rockchip,rk3399-tsadc": found on RK3399 SoCs > - reg : physical base address of the controller and length of memory mapped -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Thu, 27 Jul 2017 08:36:15 +0200 Subject: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible In-Reply-To: <1500973788-14627-2-git-send-email-rocky.hao@rock-chips.com> References: <1500973788-14627-1-git-send-email-rocky.hao@rock-chips.com> <1500973788-14627-2-git-send-email-rocky.hao@rock-chips.com> Message-ID: <4621265.xPXIvBV6Fl@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rocky, Am Dienstag, 25. Juli 2017, 17:09:44 CEST schrieb Rocky Hao: > attempt to new compatible for thermal founding on RK3328 SoC. > > Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c > Signed-off-by: Rocky Hao generally looks good but you should not have gerrit Change-Ids in patches for mainline. This is true for all patches in this series. Heiko > --- > Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index > 43003aec94bd..e3a6234fb1ac 100644 > --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible : should be "rockchip,-tsadc" > "rockchip,rk3228-tsadc": found on RK3228 SoCs > "rockchip,rk3288-tsadc": found on RK3288 SoCs > + "rockchip,rk3328-tsadc": found on RK3328 SoCs > "rockchip,rk3368-tsadc": found on RK3368 SoCs > "rockchip,rk3399-tsadc": found on RK3399 SoCs > - reg : physical base address of the controller and length of memory mapped From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbdG0Ggi (ORCPT ); Thu, 27 Jul 2017 02:36:38 -0400 Received: from gloria.sntech.de ([95.129.55.99]:33364 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbdG0Ggg (ORCPT ); Thu, 27 Jul 2017 02:36:36 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Rocky Hao Cc: rui.zhang@intel.com, edubezval@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, shawn.lin@rock-chips.com, cl@rock-chips.com, william.wu@rock-chips.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, xxx@rock-chips.com, jay.xu@rock-chips.com, wxt@rock-chips.com, huangtao@rock-chips.com Subject: Re: [PATCH 1/5] dt-bindings: rockchip-thermal: Support the RK3328 SoC compatible Date: Thu, 27 Jul 2017 08:36:15 +0200 Message-ID: <4621265.xPXIvBV6Fl@diego> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1500973788-14627-2-git-send-email-rocky.hao@rock-chips.com> References: <1500973788-14627-1-git-send-email-rocky.hao@rock-chips.com> <1500973788-14627-2-git-send-email-rocky.hao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rocky, Am Dienstag, 25. Juli 2017, 17:09:44 CEST schrieb Rocky Hao: > attempt to new compatible for thermal founding on RK3328 SoC. > > Change-Id: Ie6f6d7b4e545891a0035851a923c0412f584140c > Signed-off-by: Rocky Hao generally looks good but you should not have gerrit Change-Ids in patches for mainline. This is true for all patches in this series. Heiko > --- > Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index > 43003aec94bd..e3a6234fb1ac 100644 > --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt > @@ -4,6 +4,7 @@ Required properties: > - compatible : should be "rockchip,-tsadc" > "rockchip,rk3228-tsadc": found on RK3228 SoCs > "rockchip,rk3288-tsadc": found on RK3288 SoCs > + "rockchip,rk3328-tsadc": found on RK3328 SoCs > "rockchip,rk3368-tsadc": found on RK3368 SoCs > "rockchip,rk3399-tsadc": found on RK3399 SoCs > - reg : physical base address of the controller and length of memory mapped