From: Jeff Garzik <jeff@garzik.org>
To: Ulrich Eckhardt <doomster@knuut.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] use C99 initialisers for PCI_VDEVICE()
Date: Sun, 15 Apr 2007 08:53:37 -0400 [thread overview]
Message-ID: <46222051.9010104@garzik.org> (raw)
In-Reply-To: <200704151234.37463.doomster@knuut.de>
Ulrich Eckhardt wrote:
> (Note: CC me please, I'm not subscribed.)
>
> Not much to say about the patch (it's against 2.6.20.6), it just converts a
> macro to generate C99-style initialisers.
>
> --- include/linux/pci.h (revision 17)
> +++ include/linux/pci.h (working copy)
> @@ -407,9 +407,10 @@
> * private data.
> */
>
> -#define PCI_VDEVICE(vendor, device) \
> - PCI_VENDOR_ID_##vendor, (device), \
> - PCI_ANY_ID, PCI_ANY_ID, 0, 0
> +#define PCI_VDEVICE(vend, dev) \
> + .vendor=PCI_VENDOR_ID_##vend, .device=(dev), \
> + .subvendor=PCI_ANY_ID, .subdevice=PCI_ANY_ID, \
> + .class=0, .class_mask=0
NAK. C99 initializers were intentionally avoided. Look at the usage of
this macro.
Jeff
next prev parent reply other threads:[~2007-04-15 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 10:34 [patch] use C99 initialisers for PCI_VDEVICE() Ulrich Eckhardt
2007-04-15 12:53 ` Jeff Garzik [this message]
2007-04-15 13:32 ` Ulrich Eckhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46222051.9010104@garzik.org \
--to=jeff@garzik.org \
--cc=doomster@knuut.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.