Re: [PATCH RESEND v2 2/2] ARM: EXYNOS: Add gscaler device from DT

[Shaik Ameer Basha <shaik.ameer@samsung.com>]

Hi Sylwester,


On Tue, Jul 17, 2012 at 2:03 AM, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote:
> Hi Shaik,
>
>
> On 07/16/2012 07:33 AM, Shaik Ameer Basha wrote:
>>
>> +++ b/Documentation/devicetree/bindings/media/exynos5-gsc.txt
>> @@ -0,0 +1,16 @@
>> +* Samsung Exynos5 Gscaler device
>> +
>> +Gscaler is used for scaling and color space conversion on EXYNOS5 SoCs.
>> +
>> +Required properties:
>> +- compatible: should be "samsung,exynos-gsc"
>
>
> Shouldn't there rather be a specific "compatible" property for each SoC,
> e.g.
>    - compatible: should be one of:
>         "samsung5250,exynos-gsc",
>         "samsung5450,exynos-gsc",
> etc. ?
>


OK. I will change the compatible property to "samsung,exynos5250-gsc".


>
>> +- reg: should contian Gsaler physical address location and length.
>
>
> contian -> contain, Gsaler -> Gscaler
>


OK. I will correct that...


>
>> +- interrupts: should contain Gscaler interrupt number
>> +
>> +Example:
>> +
>> +gsc_0:  gsc@0x13e00000 {
>> +       compatible = "samsung,exynos-gsc";
>
>
>         compatible = "samsung5250,exynos-gsc";
>

Ok. I will change that to,
compatible = "samsung,exynos5250-gsc";

>
>> +       reg =<0x13e00000 0x1000>;
>> +       interrupts =<0 85 0>;
>> +};
>
>
> The aliases are still undocumented. How about adding something
> along the lines of:
>
> "Each Gscaler node should have a numbered alias in the aliases node,
> in the form of gscN, N = 0...3."
>

Thanks for that...

I resent the same patch to devicetree mailinglist... that's why aliases documentation was not present....
I will add the aliases documentation in the v3 release.

>
> ?
>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 4272b29..b945c00 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -23,6 +23,13 @@
>>         compatible = "samsung,exynos5250";
>>         interrupt-parent =<&gic>;
>>
>> +       aliases {
>> +               gsc0 =&gsc_0;
>> +               gsc1 =&gsc_1;
>> +               gsc2 =&gsc_2;
>> +               gsc3 =&gsc_3;
>> +       };
>> +
>>         gic:interrupt-controller@10481000 {
>>                 compatible = "arm,cortex-a9-gic";
>>                 #interrupt-cells =<3>;
>
>
> --
>
> Regards,
> Sylwester

Regards,
Shaik Ameer Basha